Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rule to look for plaintext "master" username and password for RDS::DBInstance #49

Closed
ghost opened this issue Oct 18, 2017 · 2 comments
Closed

Add rule to look for plaintext "master" username and password for RDS::DBInstance #49

ghost opened this issue Oct 18, 2017 · 2 comments

Comments

@ghost
Copy link

ghost commented Oct 18, 2017

In DBInstance, make sure of a few things:

  1. MasterUsername and MasterUserPassword should not be specified inline with values
  2. Given MasterUsername and MasterUserPassword are Refs to parameters - they should not have defaults
  3. Given MasterUsername and MasterUserPassword are Refs to parameters - make sure the parameters are NoEcho
This was referenced Oct 18, 2017
Closed
Closed
Closed
Closed
Closed
@xysr89 xysr89 mentioned this issue Mar 16, 2018
Closed
ghost pushed a commit that referenced this issue Mar 17, 2018
#49 add rule for finding literal passwords in RDS instance. flags lit…
22be494 
…eral, parameter that isn't NoEcho or a parameter that has a default. use the new parameters support in cfn-model
@ghost
Copy link
Author

ghost commented Mar 17, 2018

0.3.23 includes password not username

@xysr89 xysr89 mentioned this issue Mar 20, 2018
Merged
@byronic byronic self-assigned this Apr 23, 2019
@byronic
Copy link
Contributor

byronic commented Apr 23, 2019

Update: I believe this was already completed. Passing to @erickascic to verify

@byronic byronic assigned ghost and unassigned byronic Apr 23, 2019
@ghost ghost closed this as completed Apr 23, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@byronic