Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flag AWS::SDB::Domain resource as a violation #53

Closed
ghost opened this issue Oct 18, 2017 · 2 comments · Fixed by #360
Closed

Flag AWS::SDB::Domain resource as a violation #53

ghost opened this issue Oct 18, 2017 · 2 comments · Fixed by #360
Assignees
@thegonch
Labels
feature
Projects
cfn_nag

Comments

@ghost
Copy link

ghost commented Oct 18, 2017

This may be a bit cheeky but really - nobody should be using simpledb anymore
@ghost
Copy link
Author

ghost commented Oct 18, 2017

As you implement this, consider a parameterized base class for the rule that others could use to single out particular resource types they want to consider as a violation. i.e. some company may not even have a service enabled, so a rule to flag resources from that service as a violation could provide some fast upfront feedback if developers aren't aware

@ghost
Copy link
Author

ghost commented May 8, 2019

https://www.pivotaltracker.com/story/show/164842094

@ghost ghost closed this as completed May 8, 2019
@ghost ghost reopened this May 30, 2019
@ghost ghost added this to To do in cfn_nag Jan 6, 2020
@thegonch thegonch self-assigned this Feb 1, 2020
@thegonch thegonch moved this from To do to In progress in cfn_nag Feb 1, 2020
@thegonch thegonch mentioned this issue Feb 5, 2020
Merged
@thegonch thegonch linked a pull request Feb 5, 2020 that will close this issue
#53 Flag AWS::SDB::Domain resource as a violation #360
Merged
@thegonch thegonch moved this from In progress to Done in cfn_nag Feb 5, 2020
@thegonch thegonch closed this as completed Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thegonch thegonch

Labels
feature
Projects
cfn_nag
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#53 Flag AWS::SDB::Domain resource as a violation stelligent/cfn_nag
2 participants
@twellspring @thegonch