Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#53 Flag AWS::SDB::Domain resource as a violation #360

Merged
2 commits merged into from
Feb 5, 2020
Merged

#53 Flag AWS::SDB::Domain resource as a violation #360

2 commits merged into from
Feb 5, 2020

Conversation

thegonch
Copy link
Contributor

@thegonch thegonch commented Feb 5, 2020

#53

  • Adds the resource_base_rule that can be used to flag for any single resource by inheriting this rule.
  • Adds the AmazonSimpleDBDomainRule that inherits the resource_base_rule to flag a failing violation if the AWS::SDB::Domain resource is used in a CFN script.
  • Adds appropriate spec tests for both of the above new rules.

@thegonch thegonch requested a review from a team February 5, 2020 16:11
@ghost ghost merged commit 685ca8e into master Feb 5, 2020
ghost pushed a commit that referenced this pull request Feb 5, 2020
#360 pipeline failing on missing issue
40473fa
@thegonch thegonch linked an issue Feb 5, 2020 that may be closed by this pull request
Flag AWS::SDB::Domain resource as a violation #53
Closed
@ghost ghost deleted the feature/53_sdb_domain_resource_violation branch February 26, 2020 15:06
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flag AWS::SDB::Domain resource as a violation
1 participant
@thegonch