Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove need for RVM #227

Merged
merged 2 commits into from
Jun 12, 2019
Merged

Remove need for RVM #227

merged 2 commits into from
Jun 12, 2019

Conversation

kidbrax
Copy link
Contributor

@kidbrax kidbrax commented Jun 12, 2019

This runs the tests through Docker, eliminating the need for RVM

@kidbrax kidbrax requested review from a user and jesseadams June 12, 2019 14:04
Makefile Outdated
--rm \
--volume $$(pwd):/usr/src/app \
--workdir /usr/src/app \
ruby:2.6 \

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We currently support ruby 2.5.x

Copy link

@jesseadams jesseadams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passes locally, thanks @kidbrax

@jesseadams jesseadams merged commit 0c3739b into master Jun 12, 2019
@jesseadams jesseadams deleted the no-rvm branch June 12, 2019 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants