Adding custom rules and tests for issue #253 - AWS::IAM::User.LoginPr… #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
October 24, 2019 14:00
ghost
reviewed
Oct 31, 2019
|
|
||
| class IamUserLoginProfilePasswordResetRule < BaseRule | ||
| def rule_text | ||
| "IAM User Login Profile should exist and have PasswordResetRequired property set to true" |
There was a problem hiding this comment.
make sure to use single quotes if you don't need interpolation.
ghost
reviewed
Oct 31, 2019
|
|
||
| def audit_impl(cfn_model) | ||
| violating_iam_users = cfn_model.resources_by_type("AWS::IAM::User").select do |iam_user| | ||
| iam_user.loginProfile["PasswordResetRequired"].nil? || iam_user.loginProfile["PasswordResetRequired"].to_s == "false" |
There was a problem hiding this comment.
make sure to use the proper truthy? predicate here. cfn is "weakly typed" when it comes to boolean values
a few things:
- this code is going to fail when loginProfile isn't there. it's not a required field
- i'm not sure what the proper behavior is here.... i guess if there is a login profile, the password should be noecho and reset must be required?
ghost
suggested changes
Oct 31, 2019
added 3 commits
November 1, 2019 17:07
…eck for violating resources
|
@erickascic Also made some additional refactors here as well based on the MQbroker PR. |
ghost
approved these changes
Nov 16, 2019
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding custom rules and tests for issue #253 - AWS::IAM::User.LoginProfile password property rules