Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/issue 253 ops works stack rds db password #302

Merged
4 commits merged into from
Nov 16, 2019

Conversation

tmcelhattan
Copy link
Contributor

Adding custom rules and tests for issue #253 - AWS::OpsWorks::Stack.RdsDbInstance password property rules.

@tmcelhattan tmcelhattan requested a review from a user October 30, 2019 18:49
'F54'
end

def resource_type
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments for mq broker. pretty much mirror image

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apply same feedback from mq PR

@tmcelhattan
Copy link
Contributor Author

@erickascic Made some additional refactors based on the MQbroker PR

@ghost ghost merged commit 65c5679 into master Nov 16, 2019
@ghost ghost deleted the feature/issue-253-ops-works-stack-rds-db-password branch January 6, 2020 21:59
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant