have YAMLLinter use JMESPath to find resourceID

cli/yaml-linter.go

@@ -15,6 +15,15 @@ type YAMLResourceLoader struct {
 	Resources []assertion.ResourceConfig
 }
 
+func extractResourceID(expression string, properties interface{}) string {
+	resourceID := "None"
+	result, err := assertion.SearchData(expression, properties)
+	if err == nil {
+		resourceID, _ = result.(string)
+	}
+	return resourceID
+}
+
 // Load converts a text file into a collection of Resource objects
 func (l YAMLResourceLoader) Load(filename string) ([]assertion.Resource, error) {
 	resources := make([]assertion.Resource, 0)
@@ -32,7 +41,7 @@ func (l YAMLResourceLoader) Load(filename string) ([]assertion.Resource, error)
 			for _, element := range sliceOfProperties {
 				properties := element.(map[string]interface{})
 				resource := assertion.Resource{
-					ID:         properties[resourceConfig.ID].(string), // FIXME should use JMESPath to ID, and make sure it handles numbers
+					ID:         extractResourceID(resourceConfig.ID, properties),
 					Type:       resourceConfig.Type,
 					Properties: properties,
 					Filename:   filename,

example-files/config/generic.config

@@ -19,16 +19,22 @@ gadgets:
 
 other_stuff:
   contraptions:
-    - serial_number: S1000
+    - ids:
+        serial_number: S1000
+        sku: S1234
       size: 10
       locations:
         - city: Seattle
         - city: San Francisco
-    - serial_number: S2000
+    - ids:
+        serial_number: S2000
+        sku: S5678
       size: 20
       locations:
         - city: New York
-    - serial_number: S3000
+    - ids:
+        serial_number: S3000
+        sku: S0101
       size: 4000
       locations:
         - city: Paris

example-files/rules/generic.yml

@@ -16,7 +16,7 @@ resources:
     id: name
   - type: contraption
     key: other_stuff.contraptions[]
-    id: serial_number
+    id: ids.serial_number
 
 rules: