Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/exception not loaded on terraform builtin #206

Merged

Conversation

chapipo
Copy link
Contributor

@chapipo chapipo commented Jun 23, 2020

Exceptions in profile do not apply on terraform builtin rules.

It is because the exceptions are parsed before the addition of the builtin rules.

This PR add a smoke-test to reproduce the issue and fix it.

Copy link
Contributor

@kmonihen kmonihen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@kmonihen kmonihen merged commit 8e87d18 into stelligent:master Jun 25, 2020
@chapipo chapipo deleted the fix/exception-not-loaded-on-builtin branch June 26, 2020 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants