Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamic variables in mu.yml #209

Closed
cplee opened this issue Nov 2, 2017 · 3 comments
Closed

Dynamic variables in mu.yml #209

cplee opened this issue Nov 2, 2017 · 3 comments
Assignees
@timbaileyjones
Labels
enhancement
Projects
1.2.1

Comments

@cplee
Copy link
Contributor

cplee commented Nov 2, 2017

Allow referencing environment variables from mu.yml
@timbaileyjones
Copy link
Contributor

What syntax would you like to use? ${VariableName} is already taken.
Two suggestions:

  1. os.getenv('SOME_VARIABLE') make it look like python. OR
  2. $ENV{'SOME_VARIABLE'} - take a page from Perl

@cplee
Copy link
Contributor Author

cplee commented Nov 16, 2017

Let's go with ${env:SOME_VARIABLE}

timbaileyjones pushed a commit that referenced this issue Nov 17, 2017
Issue #209 - Implemented variable substitution in the form of ${env:S…
37aa96d 
…OME_VAR}

with unit tests also.
@cplee cplee added this to Under Review in 1.2.1 Nov 17, 2017
@cplee
Copy link
Contributor Author

cplee commented Nov 21, 2017

Merged #224

@cplee cplee closed this as completed Nov 21, 2017
1.2.1 automation moved this from Under Review to Done Nov 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timbaileyjones timbaileyjones

Labels
enhancement
Projects
No open projects
1.2.1
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@timbaileyjones @cplee