Issue #214 - Added DeployTimeout to allow pipline timeout override #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows users to override the default 30 minutes for deploy timeouts in acceptance, production, and build pipelines - Moved the params assignment into an exported method for easier testing of param assignment - Added test to ensure timeout was read and set for each pipeline Issue #214 - Added parameters for deploy timeout Allows users to override the default 30 minutes for deploy timeouts in acceptance, production, and build pipelines Issue #214 - Pull params building out of upsert for testing Moved the params assignment into an exported method for easier testing of param assignment. Issue #214 - Added test for build timeout in mu yaml Issue #214 - Renamed DeployTimeout to BuildTimeout to reflect use Accidentally named the Struct properties BuildTimeout when they only affect DeployTimeout settings. Renamed to avoid confusion and allow for having a separate deploy timeout in the future
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #214 to add timeout for deploy pipelines. I only parameterized the build steps. The 30 hard minute timeout is still in place for the artifact storage steps.