Decompose upsert method to be less complex #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This ended up going further and refactored everything over a CCM of 15. It also fixes spots where error returns weren't being checked and other stuff revealed by gometalinter |
cplee
suggested changes
Sep 19, 2018
jeffb4
force-pushed
the
refactor-upsert-function
branch
from
c389f45
to
98889dc
Compare
cplee
suggested changes
Sep 22, 2018
workflows/environment_upsert.go
Outdated
| common.EnvProviderEc2: map[string]string{ | ||
| "templateName": "env-ec2.yml", | ||
| "imagePattern": ec2ImagePattern, | ||
| "launchType": ""}} |
There was a problem hiding this comment.
this caused an error in the e2e testing since it tried to set the LaunchType stack parameter to empty string...but that param doesn't exist in the ec2 provider template. maybe update line 256 to only set the value iff launchType is in the map and not empty string?
cplee
approved these changes
Sep 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaks UpsertStack into several methods, and attempts to share logic between update/create (but has to use reflection for that which is meh)