Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not load TestContainersConfiguration when not needed #22

Closed
vraybaud opened this issue May 14, 2020 · 0 comments · Fixed by #24
Closed

Do not load TestContainersConfiguration when not needed #22

vraybaud opened this issue May 14, 2020 · 0 comments · Fixed by #24
Assignees
@vraybaud
Labels
fix Something isn't working

Comments

@vraybaud
Copy link
Contributor

The TestContainersConfiguration is loaded for tests that don't need it.
This should be loaded only in tests needing a Neo4J
@vraybaud vraybaud added the bug label May 14, 2020
@vraybaud vraybaud self-assigned this May 14, 2020
vraybaud pushed a commit that referenced this issue May 14, 2020
@vraybaud
fix: do not load test configuration in every tests #22
93ecd2a 
fix: fix broken test after removal of Neo4J DB #22
vraybaud pushed a commit that referenced this issue May 14, 2020
@vraybaud
fix: load when needed TestContainersConfiguration & fix broken test a…
a03d264 
…fter removal of Neo4J DB #22
@vraybaud vraybaud added this to To do in Roadmap via automation May 14, 2020
vraybaud pushed a commit that referenced this issue May 14, 2020
@vraybaud
fix: load when needed TestContainersConfiguration & fix broken test a…
0eafcd4 
…fter removal of Neo4J DB #22
vraybaud pushed a commit that referenced this issue May 14, 2020
@vraybaud
fix: load when needed TestContainersConfiguration & fix broken test a…
892c32d 
…fter removal of Neo4J DB #22
vraybaud pushed a commit that referenced this issue May 14, 2020
@vraybaud
fix: load when needed TestContainersConfiguration & fix broken test a…
48c8105 
…fter removal of Neo4J DB #22
@vraybaud vraybaud mentioned this issue May 14, 2020
Merged
@bobeal bobeal linked a pull request May 15, 2020 that will close this issue
fix: load when needed TestContainersConfiguration & fix broken test a… #24
Merged
Roadmap automation moved this from To do to Done May 15, 2020
bobeal pushed a commit that referenced this issue May 15, 2020
@vraybaud
fix: load TestContainersConfiguration only when needed by a test #22
4259cd7 
- fix: load when needed TestContainersConfiguration
- fix broken test after removal of Neo4J DB
- fix: use relaxed Mock bean to avoid boilerplate code

Co-authored-by: Vincent Raybaud <vincent.raybaud@eglobalmark.com>
@bobeal bobeal removed this from Done in Roadmap May 18, 2020
@bobeal bobeal added fix Something isn't working and removed bug labels Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vraybaud vraybaud

Labels
fix Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@bobeal @vraybaud