Feature/support_r2r #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
First I was skeptic about your use of Docker for testing but it seems to work nicely. I will just add some prefixes so it gets easier to compare with the rosrust integration. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I appreciate sharing useful crate.
I've added r2r support and its tests in this PR.
https://github.com/sequenceplanner/r2r
Since that is an ros2 crate, I believe another workflow setting is needed.
So I've prepared it referencing following r2r's test in the commit 083ac0c.
https://github.com/sequenceplanner/r2r/blob/master/.github/workflows/rust_and_ros2.yml
This commit might have to be modified to maintainer's preferences.
I've also confirmed all tests pass.