Allow to select a slot (e.g. scaled, raw etc..) in join_features() #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make get_abundance_sc_long accept assay and slot selection
stemangiola
requested changes
Aug 21, 2023
stemangiola
requested changes
Aug 21, 2023
R/utilities.R
Outdated
| #' | ||
| #' @return A Seurat object | ||
| #' | ||
| #' @export | ||
| get_abundance_sc_long = function(.data, features = NULL, all = FALSE, exclude_zeros = FALSE){ | ||
| get_abundance_sc_long = function(.data, features = NULL, all = FALSE, exclude_zeros = FALSE, assay = .data@active.assay, slot = "data"){ |
There was a problem hiding this comment.
assay here is not needed as we will return all assays (inside the function is clear).
R/utilities.R
Outdated
Comment on lines
194
to
199
|
|
||
| DefaultAssay(.data) = assay | ||
| for(i in Assays(.data) %>% setdiff(assay)) { | ||
| .data[[i]] = NULL | ||
| } | ||
|
|
There was a problem hiding this comment.
This is not needed as we return all assays
|
Thank you very much for your prompt review. I apologize for the misinterpretation of the feature. I have removed the |
stemangiola
requested changes
Aug 21, 2023
stemangiola
approved these changes
Aug 21, 2023
|
Condrats! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@stemangiola
I have made the following changes to
join_features()and checked thatR CMD CHECKdoes not produce any warnings or errors. I would be grateful if you could review the PR.assayslotandprefixinget_abundance_sc_wide()get_abundance_sc_long()handleassayandslotspecificationassayslotinget_abundance_sc_long()assayslotand...injoin_features()