fix: cleanup requests when resolved

stencila · Nov 27, 2018 · 57ff010 · 57ff010
1 parent 997a268
commit 57ff010
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/src/comms/Client.ts b/src/comms/Client.ts
@@ -131,5 +131,7 @@ export default abstract class Client {
     const resolve = this.requests[responseObj.id]
     if (!resolve) throw new Error(`No request found for response with id: ${responseObj.id}`)
     resolve(responseObj)
+    // Clean up by deleting the request entry
+    delete this.requests[responseObj.id]
   }
 }
diff --git a/tests/comms/StdioClient.test.js b/tests/comms/StdioClient.test.js
@@ -47,4 +47,7 @@ test('StdioClient', async () => {
       expect(error.message).toEqual("Internal error: Unhandled import format: bar/baz")
     }
   }
+
+  // There should be no more requests waiting for a response
+  expect(Object.keys(client.requests).length).toEqual(0)
 })