Skip to content

Commit

Permalink
fix: changes in cardinality and corrections to tests
Browse files Browse the repository at this point in the history
  • Loading branch information
nokome committed Apr 11, 2019
1 parent 0fc0207 commit a5258fc
Show file tree
Hide file tree
Showing 6 changed files with 40 additions and 34 deletions.
3 changes: 2 additions & 1 deletion examples/brand/simple.brand.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
type: Brand
logo: https://stenci.la/img/icons/stencil-machine.svg
review: 'Awful. Broke my computer and research.'
reviews:
- 'Awful. Broke my computer and research.'
9 changes: 4 additions & 5 deletions examples/invalid/invalid.brand.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
type: Brand
logo:
42
logo: 42
# Incorrect type. Expected a URI.
review:
https://stenci.la/review.html
# Incorrect type. Expected "string".
reviews:
- []
# Incorrect type. Expected "string".
20 changes: 11 additions & 9 deletions examples/invalid/invalid.organization.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,17 +2,19 @@ type: Organization
address:
- '12 Random Road, Random Town, Aotearoa'
# Incorrect type. Expected "string".
brand:
logo:
- https://stenci.la/img/icons/stencil-machine.svg
review: 4567
contactPoint:
availableLanguages: 'English'
email: 'english@email.com'
telephone: (00)64-9775673
brands:
- logo:
- https://stenci.la/img/icons/stencil-machine.svg
review: 4567
contactPoints:
- type: ContactPoint
availableLanguages: 'English'
email: 'english@email.com'
telephone: (00)64-9775673
departments: Computer Science
# Incorrect type. Expected "array".
email: mailto:organization@organization.com
emails:
- mailto:organization@organization.com
# String is not an e-mail address.
funders:
- simple.person.yaml
Expand Down
31 changes: 16 additions & 15 deletions examples/organization/simple.organization.yaml
Original file line number Diff line number Diff line change
@@ -1,22 +1,23 @@
type: Organization
address: '12 Random Road, Random Town, Aotearoa'
brand:
logo:
- https://stenci.la/img/icons/stencil-machine.svg
review:
- 'Awful. Broke my computer and research.'
contactPoint:
availableLanguages:
- 'English'
- 'French'
emails:
- 'english@email.com'
- 'french@email.com'
telephone:
- '+649775673'
brands:
- type: Brand
logo: https://stenci.la/img/icons/stencil-machine.svg
reviews:
- 'Awful. Broke my computer and research.'
contactPoints:
- type: ContactPoint
availableLanguages:
- 'English'
- 'French'
emails:
- 'english@email.com'
- 'french@email.com'
telephone: '+649775673'
departments:
- type: Organization
email: organization@organization.com
emails:
- organization@organization.com
funders:
- type: Person
givenNames:
Expand Down
3 changes: 2 additions & 1 deletion examples/product/simple.product.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,6 @@ type: Product
brand:
type: Brand
logo: https://stenci.la/img/icons/stencil-machine.svg
review: 'Awful. Broke my computer and research.'
reviews:
- 'Awful. Broke my computer and research.'
productID: 675ef78
8 changes: 5 additions & 3 deletions schema/organization/Brand.schema.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,10 @@ properties:
anyOf:
- $ref: URL.schema.yaml
- $ref: ImageObject.schema.yaml
review:
reviews:
'@id': schema:review
description: |
Short review of the brand and/or the products it represents.
type: string
Short reviews of the brand and/or the products it represents.
type: array
items:
type: string

0 comments on commit a5258fc

Please sign in to comment.