Functions #135
Merged
Functions #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@michael : thanks for this. Will take a look and if I need to do anything will work on the functions branch |
|
Feel free to merge this. Just wanted to give you a place to review and check if it breaks things. It's not really complete yet, but hope you can pick it up from there. I don't have much time in the coming days, but if you have questions ping me. |
alex-ketch
pushed a commit
that referenced
this pull request
Oct 27, 2021
Fix ts-node theme import failing package genereation
nokome
pushed a commit
that referenced
this pull request
Jan 26, 2022
nokome
pushed a commit
that referenced
this pull request
Jan 26, 2022
# [0.33.0](stencila/schema@v0.32.4...v0.33.0) (2020-01-19) ### Features * **JSON Schema:** Generate union type for descendant types ([3376d73](stencila/schema@3376d73)) * **Type Guards:** Add isInstanceOf guard for matching descendant types ([9985936](stencila/schema@9985936)), closes [#135](stencila/schema#135)
|
🎉 This issue has been resolved in version 1.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First iteration on integrating functions with the backend.
We still don't update the list of available functions automatically. However the improved FunctionComponent now fetches the function spec on demand. It displays a loading state while the spec is loaded.
I put a bunch of todo items to give you some pointers for where to iterate next.
You may want to study the lifecycle section of FunctionComponent as that's the general pattern to 'synchronize' async data for a synchronous rendering. The component is modelled as a state machine describing transitions. In our case it's just loading (func is null) or loaded (func is set).