Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] Add annotation to ignore deploy/sts from being monitored by the agent #30

Closed
NoUseFreak opened this issue Jan 3, 2023 · 1 comment
Closed

[feature] Add annotation to ignore deploy/sts from being monitored by the agent #30

NoUseFreak opened this issue Jan 3, 2023 · 1 comment
Labels
beginnner friendly Issues or requests ideal for beginners feature request New feature requests released

Comments

@NoUseFreak
Copy link
Member

Is your feature request related to a problem? Please describe.

A clear and concise description of what the problem is - e.g. "I'm always frustrated when [...]"

Add annotation to ignore deploy/sts from being monitored by the agent.
Some applications, like ledger itself, might skew the statistics.

Describe the solution you'd like

What would the feature look like? How would it work? How would it change the API?

Ignores deployments and statefulsets with the annotation ledger.stenic.io/ignore=true

Describe alternatives you've considered

Are there alternatives you've tried, and/or workarounds in-place?
@NoUseFreak NoUseFreak added feature request New feature requests beginnner friendly Issues or requests ideal for beginners labels Jan 3, 2023
NoUseFreak added a commit that referenced this issue Jan 17, 2023
@NoUseFreak
fix: Ignore self by defaul. #30
6ed489f
github-actions bot pushed a commit that referenced this issue Jan 17, 2023
@semantic-release-bot
chore(release): 1.12.0
93002d1 
# [1.12.0](v1.11.0...v1.12.0) (2023-01-17)

### Bug Fixes

* Ignore self by defaul. [#30](#30) ([6ed489f](6ed489f))

### Features

* Add ignore annotation ([0f0ddf9](0f0ddf9)), closes [#30](#30)
@NoUseFreak
Copy link
Member Author

🎉 This issue has been resolved in version 1.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
beginnner friendly Issues or requests ideal for beginners feature request New feature requests released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@NoUseFreak