Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker fix fails when tag not specified for image #1932

Closed
2 tasks
varunsh-coder opened this issue Feb 19, 2023 · 3 comments
Closed
2 tasks

Docker fix fails when tag not specified for image #1932

varunsh-coder opened this issue Feb 19, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@varunsh-coder
Copy link
Member

assumes that a tag is always specified. When it is not specified, the code fails.

Here is an example
https://github.com/onnx/onnx/blob/540c58b4fa622c99880bcd2ea086089cae56bc9d/.github/workflows/release_linux_x86_64.yml#L46

  • We need to figure out how to fix an issue when the tag is not specified.
  • Handle cases when the tag is not specified and not error out
@varunsh-coder varunsh-coder added the bug Something isn't working label Feb 19, 2023
@zwass
Copy link

zwass commented Mar 1, 2023

@varunsh-coder varunsh-coder changed the title Docker fix fails when not tag specified for image Docker fix fails when tag not specified for image Mar 1, 2023
@varunsh-coder
Copy link
Member Author

Thanks, @zwass, for updating the issue and trying this out!

I have added a couple of related issues based on your PR.
#1955
#1954

@varunsh-coder
Copy link
Member Author

This issue is fixed in v1.3.1 and released. #1954 is also fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants