Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python3 port for SCL library? #407

Closed
devonsparks opened this issue May 8, 2021 · 5 comments
Closed

Python3 port for SCL library? #407

devonsparks opened this issue May 8, 2021 · 5 comments

Comments

@devonsparks
Copy link
Contributor

Hi all,

I've been using the SCL library embedded in exp2python (link to source) to good effect for some IFC-based experiments. SCL is currently written for Python 2.x. I have a need to use it in combination with some libraries that only support Python 3.x. If I were to submit a PR adding Python3 support for SCL, is it better to:

  1. Port SCL directly to Python3, given that Python2 is sunset (source)
  2. Use something like Python-Future to support simultaneous Python2 and Python3 compatibility?

Another way to ask this might be: Do we have good reason to continue to maintain Python2 support for SCL?

Thanks!

@tpaviot
Copy link
Member

tpaviot commented May 8, 2021

I choose 1. The only reason I see to maintain a Python2 version would be that someone here raises his hand and ask for this support. I guess it won't happen.

@cshorler
Copy link
Member

cshorler commented May 8, 2021 via email

@brlcad
Copy link
Member

brlcad commented May 10, 2021

Yeah, I would say Py3. If someone wants to backport and maintain support for Py2, I don't think I'd object, but priority would be making sure Py3 works well once it's converted.

@devonsparks
Copy link
Contributor Author

Thanks all. I've made most of the changes required for a Py3 port (testing now - PR coming soon 🤞). I figured it was a good time to update the setuptools configuration so the package can properly self-install along with its dependencies. This would also let us publish the package to PyPI.

Any thoughts on renaming the Python SCL package to something like stepcode or pystepcode? This would reduce ambiguity when published to a package repository like PyPI and bring the naming convention in line with the rest of the project. I didn't see other parts of stepcode depending on the Python SCL library, so the rename appears harmless, but wanted to check. If we're unsure, I can send a PR with the existing SCL naming convention, and we can return to this later.

Thanks!

@cshorler
Copy link
Member

this has been implemented and merged to develop

#408 and #429 and others

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants