feat(frame): add handling of non-empty frame recorders before sending

stepfunc · May 22, 2024 · 488e085 · 488e085
1 parent 3df08a3
commit 488e085
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/rodbus/src/serial/frame.rs b/rodbus/src/serial/frame.rs
@@ -221,7 +221,7 @@ pub(crate) fn format_rtu_pdu(
     msg.serialize(cursor, Some(&mut records))?;
 
     if !records.records_empty() {
-        //TODO(Kay): We need to inform the user about a forgotten empty lonely byte :( (NOTE: Only user of this API is probably me but whatever :) )
+        return Err(RequestError::FrameRecorderNotEmpty)
     }
     let end_pdu_body = cursor.position();
     // Write the CRC

diff --git a/rodbus/src/tcp/frame.rs b/rodbus/src/tcp/frame.rs
@@ -150,7 +150,7 @@ pub(crate) fn format_mbap(
     msg.serialize(cursor, Some(&mut records))?;
 
     if !records.records_empty() {
-        //TODO(Kay): Again we need to pass this error up !
+        return Err(RequestError::FrameRecorderNotEmpty)
     }
     let end_pdu = cursor.position();