Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid copying MBAP frame data #1

Closed
jadamcrain opened this issue Dec 20, 2019 · 1 comment
Closed

Avoid copying MBAP frame data #1

jadamcrain opened this issue Dec 20, 2019 · 1 comment
Assignees
@jadamcrain @emgre
Labels
optimization non-feature code optimization

Comments

@jadamcrain
Copy link
Member

Currently Frame contains a static buffer, which gets copied. It should point to a slice in another buffer.
@jadamcrain jadamcrain added the optimization non-feature code optimization label Dec 20, 2019
@jadamcrain jadamcrain added this to the 0.1.0 release milestone Dec 20, 2019
@jadamcrain jadamcrain removed this from the 0.1.0 release milestone Jan 2, 2020
@jadamcrain
Copy link
Member Author

This can be done after 0.1.0 release since it's all internal

grewek pushed a commit to grewek/rodbus that referenced this issue Feb 19, 2024
@biancode
Merge pull request stepfunc#1 from thr2240/boris/custom-buffer
30463e6 
feat: implement send/receive custom buffer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jadamcrain jadamcrain

@emgre emgre

Labels
optimization non-feature code optimization
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jadamcrain @emgre