Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spaces not supported in paths in most scripts #20

Open
hsandt opened this issue Jul 5, 2019 · 1 comment
Open

Spaces not supported in paths in most scripts #20

hsandt opened this issue Jul 5, 2019 · 1 comment

Comments

@hsandt
Copy link

hsandt commented Jul 5, 2019

Most of the run/bundle scripts miss quotes around paths containing variables such as $DIR on Linux or %~dp0 on Windows.

As a result, the scripts won't work if any folder contains a space in the tree leading to the Ruby Ship install.

For instance, on Windows, if you copied Ruby Ship in "D:\Video Games", you will get:

'D:\Video' is not recognized as an internal or external command,
operable program or batch file.

I have fixed the scripts I just needed locally, but to make a proper PR I'd need to go through all of them and test them on different platforms... I'm just using Ruby Ship to release a Ruby project once, so I'm unlikely to spend too much time on it. I hope that at least, this ticket will help those looking for a local fix or willing to make a PR.

@stephan-nordnes-eriksen
Copy link
Owner

Thanks for notifying!

I will have a look into it. It is likely a problem on multiple platforms as you mention. If you have fixed it on your platform I would be really happy for a PR which fixes only that one platform, and I (or someone else) can have a go at the others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants