Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: delays in indexing times can cause keys to get lost when creating new signer #11

Closed
stephancill opened this issue Oct 28, 2023 · 0 comments · Fixed by #38
Closed
Labels
bug Something isn't working

Comments

@stephancill
Copy link
Owner

stephancill commented Oct 28, 2023

A brand new signer keypair is generated on mounting of the sign in with warpcast/ethereum component. This means that if the modal closes for some reason while waiting for the new signer transaction to be confirmed/the warpcast API to respond, the key will be lost.

This key should be persisted with an expiry time and loaded while the expiry time is not in the past. On mount, the component should check if the key in localstorage has been indexed, and if so, should add it to the list of signers and skip the step of registering it as a new signer.

@stephancill stephancill added the bug Something isn't working label Oct 28, 2023
@stephancill stephancill mentioned this issue Jul 4, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant