Added function "modbus_read_device_information_object" #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlp
reviewed
Jul 31, 2018
src/modbus.c
Outdated
| for (i = 0; i < rc; i++) { | ||
| dest[i] = rsp[offset + i]; | ||
| } | ||
| dest[i] = '\0'; |
There was a problem hiding this comment.
this looks dubious. While objects 1..6 are ascii per spec, the rest are all user defined. Should this function not just return the length as is done in many other libmodbus functions?
There was a problem hiding this comment.
Probably yes. I will change it.
|
You need to include documentation for your new functions too |
|
I will also add the documentations and update the PR. |
Added function "modbus_read_device_information_object" to access device specific information like "vendor name" or "product name". Definitions for device information objects are added to modbus.h. Signed-off-by: Oliver Schwaneberg <oliver.schwaneberg@gmail.com>
Schwaneberg
force-pushed
the
read-device-info
branch
from
4c4abd6
to
14c4269
Compare
|
I have updated the PR. Please take a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new function to access the built in device information from Modbus devices.
Changes:
Notes:
I successfully tested to code with a server that uses big endian word and byte order. Therefore, the mapping in modbus.c:1432 might be wrong for clients with little endian word order, depending on how strings are handled.
Signed-off-by: Oliver Schwaneberg oliver.schwaneberg@gmail.com