address check in single register / coil responses added #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to Modbus standard the address of single register / coils request and response must match
mhei
reviewed
Dec 14, 2018
|
Retrigger Travis build |
|
@mhei Is there still something I need to for this to get merged? |
|
@mhei friendly ping |
|
I'd squash both commits and force push to this branch. I can't do much more here other than commenting... |
stephane
approved these changes
Jul 19, 2022
|
Github didn't use the expected commit title in the squashed commit but it's merged. |
epsilonrt
pushed a commit
to epsilonrt/libmodbus
that referenced
this pull request
Jun 19, 2023
Address check in single register / coil responses added According to Modbus standard the address of single register / coils request and response must match Co-authored-by: Heinrich Gsponer <heinrich.gsponer@siemens.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to Modbus standard the address of single register / coils request and response must match