address comments

stephanenicolas · Oct 21, 2019 · 35659ed · 35659ed
1 parent e4139ef
commit 35659ed
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 19 deletions.
diff --git a/...-sample/src/test/java/com/example/toothpick/activity/AdvancedBackpackItemsActivityTest.kt b/...-sample/src/test/java/com/example/toothpick/activity/AdvancedBackpackItemsActivityTest.kt
@@ -1,6 +1,5 @@
 package com.example.toothpick.activity
 
-import com.google.common.truth.Truth.assertThat
 import com.nhaarman.mockitokotlin2.doReturn
 import com.nhaarman.mockitokotlin2.mock
 import com.nhaarman.mockitokotlin2.spy
@@ -29,9 +28,6 @@ internal class AdvancedBackpackItemsActivityTest {
     mockActivity.injectDependencies()
 
     //TEST
-    assertThat(mockActivity.viewModel).isNotNull()
-    assertThat(mockActivity.viewModel.backpack).isNotNull()
-    assertThat(mockActivity.notificationHelper).isNotNull()
-    assertThat(mockActivity.viewAdapter).isNotNull()
+    //if injection didn't create, the graph is valid
   }
-}
+}
diff --git a/...ck-sample/src/test/java/com/example/toothpick/activity/SimpleBackpackItemsActivityTest.kt b/...ck-sample/src/test/java/com/example/toothpick/activity/SimpleBackpackItemsActivityTest.kt
@@ -1,15 +1,8 @@
 package com.example.toothpick.activity
 
-import com.google.common.truth.Truth.assertThat
 import org.junit.Test
-import org.junit.jupiter.api.extension.RegisterExtension
-import toothpick.testing.ToothPickExtension
 
 internal class SimpleBackpackItemsActivityTest {
-
-  @field:RegisterExtension
-  var toothPickRule = ToothPickExtension(this)
-
   /**
    * In this test, we demonstrate how to unit test
    * a call to inject on an entry point such as an activity.
@@ -25,9 +18,6 @@ internal class SimpleBackpackItemsActivityTest {
     activity.injectDependencies()
 
     //TEST
-    assertThat(activity.backpack).isNotNull()
-    assertThat(activity.notificationHelper).isNotNull()
-    assertThat(activity.viewAdapter).isNotNull()
+    //if injection didn't create, the graph is valid
   }
-
-}
+}
diff --git a/toothpick-testing-junit5/src/test/java/toothpick/testing/TestMocking.java b/toothpick-testing-junit5/src/test/java/toothpick/testing/TestMocking.java
@@ -30,7 +30,7 @@
 class TestMocking {
 
   @RegisterExtension ToothPickExtension toothPickExtension = new ToothPickExtension(this, "Foo");
-  @RegisterExtension MockitoExtension easyMockExtension = new MockitoExtension(this);
+  @RegisterExtension MockitoExtension mockitoExtension = new MockitoExtension(this);
 
   @Mock Dependency dependency;