TP 2.0 #320
Merged
TP 2.0 #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlemures
commented
Feb 1, 2019
toothpick-runtime/build.gradle
Outdated
| testImplementation deps.easymock | ||
| testImplementation deps.powermock | ||
| testImplementation deps.hamcrest | ||
| testImplementation files(Jvm.current().getToolsJar()) | ||
| testImplementation 'org.powermock:powermock-module-junit4-rule-agent:1.6.4' |
There was a problem hiding this comment.
this should go inside deps
dlemures
commented
Feb 1, 2019
| testAnnotationProcessor project(':toothpick-compiler') | ||
| } | ||
|
|
||
| test { | ||
| jvmArgs '-noverify' | ||
| } |
There was a problem hiding this comment.
should we keep this?
There was a problem hiding this comment.
yes, powermock breaks the java 7 byte code frames otherwise.
dlemures
commented
Feb 1, 2019
| jacocoTestReport { | ||
| reports { | ||
| xml.enabled = false | ||
| html.enabled = false |
There was a problem hiding this comment.
dont need this anymore?
smoothie-androidx/gradle.properties
Outdated
| POM_ARTIFACT_ID=smoothie-androidx | ||
| POM_NAME=smoothie android X | ||
| POM_DESCRIPTION='Toothpick package providing Android providers for the android X library' | ||
| POM_PACKAGING='aar' |
| assertThat(loaderManager, notNullValue()); | ||
| assertThat(layoutInflater, notNullValue()); | ||
| } | ||
| } |
| import toothpick.registries.FactoryRegistryLocator; | ||
| import toothpick.registries.MemberInjectorRegistryLocator; | ||
| import toothpick.locators.FactoryLocator; | ||
| import toothpick.locators.MemberInjectorLocator; |
smoothie-support/gradle.properties
Outdated
| POM_ARTIFACT_ID=smoothie-support | ||
| POM_NAME=smoothie support | ||
| POM_DESCRIPTION='Toothpick package providing Android providers for the support library' | ||
| POM_PACKAGING='aar' |
| @@ -0,0 +1,2 @@ | |||
| toothpick.compiler.factory.FactoryProcessor,isolating | |||
| toothpick.compiler.memberinjector.MemberInjectorProcessor,isolating | |||
toothpick-runtime/build.gradle
Outdated
| options.annotationProcessorPath = configurations.testAnnotationProcessor | ||
| options.compilerArgs = ['-Atoothpick_registry_package_name=toothpick.test', | ||
| '-Atoothpick_annotations=toothpick.data.CustomScope',] | ||
| options.compilerArgs = ['-Atoothpick_annotations=toothpick.data.CustomScope',] | ||
| } | ||
|
|
||
| apply from: rootProject.file('gradle/gradle-mvn-push.gradle') |
| //THEN | ||
| assertThat(memberInjector, nullValue()); | ||
| } | ||
| } |
| //THEN | ||
| fail("Should throw an exception"); | ||
| } | ||
| } |
| TestModule() { | ||
| bind(Computer.class).toInstance(mockComputer); | ||
| } | ||
| } | ||
| } |
| POM_ARTIFACT_ID=toothpick-testing-junit4 | ||
| POM_NAME=Toothpick Testing Junit 4 | ||
| POM_DESCRIPTION='Junit 4 Testing support for Toothpick' | ||
| POM_PACKAGING='jar' |
| POM_ARTIFACT_ID=toothpick-testing-junit5 | ||
| POM_NAME=Toothpick Testing Junit 5 | ||
| POM_DESCRIPTION='Junit 5 Testing support for Toothpick' | ||
| POM_PACKAGING='jar' |
|
really you rock @dlemures |
dlemures
force-pushed
the
dlemures/removing-registries
branch
from
868c36d
to
975cd20
Compare
stephanenicolas
force-pushed
the
dlemures/removing-registries
branch
from
d353ee7
to
975cd20
Compare
dlemures
force-pushed
the
dlemures/removing-registries
branch
from
975cd20
to
056229f
Compare
|
You are the one that rocks little penguin 🐥 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we reworked on registries to enable obfuscation. Reflection is now used to load the factories and member injectors,
this is normal (and all other annotation processor based libs do that too) and there is no impact on performance.
__instead of$$to make TP more compliant with some tools.smoothie-support and smoothie-androidx that respectively support the old legacy support library and the new android X libs).
make the sample work with incremental compilation (there is a bug in my fork of incap that I can repro with smoothie-sample !). This won't be fixed now.