Tp 3 #346

dlemures · 2019-07-29T23:17:21Z

No description provided.

…er scopes annotations.

…separately as a new project

…bindings to internal provider. Now bindings DSL is more clear: it can only ***add*** things to annotated bound classes. Annotations will always be taken into account, whether or not we use bindinds vs dynamic discovery. Bindings DSL can emulate having added annotations.

… well together. DSL is not yet fully tested. TODO: add the possibility to define in which scope a binding should go based on scope annotations

…orks well, we can now define scope very accurately in the DSL

…asses using a scope annotation can only be installed in scope supporting this annotation. It means that all bindings will always be scoped in the scope where they are installed.

…ted in tests, docs and code.

…cally when life cycle owner is destroyed

…extension though

… make sense to have them here, we subclass and change the configuration.

coveralls · 2019-07-30T04:49:37Z

Coverage decreased (-0.5%) to 95.192% when pulling 7f87a05 on tp-3 into 54476ca on master.

stephanenicolas

Also: Create a ticket for TP 3.1.0 where we add a base class for factories, in order to generate less code for factories, reduce the size of the final jar/apk. It will impact many tests.

stephanenicolas · 2019-07-30T05:07:38Z

ktp/src/main/kotlin/toothpick/ktp/delegate/DelegateNotifier.kt

+
+class DelegateNotifier {
+
+    private val delegatesMap: MutableMap<Any, MutableList<InjectDelegate<out Any>>> = Collections.synchronizedMap(WeakHashMap())


We normally use the convention mapFooToBar. Here it would be mapContainerToDelegates

stephanenicolas · 2019-07-30T05:10:12Z

ktp/src/main/kotlin/toothpick/ktp/extension/ScopeExtension.kt

@@ -0,0 +1,25 @@
+/*


We have to make this more uniform. Sometimes we use Extension suffix with an s and sometimes not.

stephanenicolas · 2019-07-30T05:11:00Z

ktp/src/test/kotlin/toothpick/ktp/KTPTest.kt

+    }
+
+    @Test
+    fun `openScope should open scope and wrap it using KTPScope`() {


stephanenicolas · 2019-07-30T05:11:04Z

ktp/src/test/kotlin/toothpick/ktp/KTPTest.kt

+    }
+
+    @Test
+    fun `openScope should open scope and wrap it using KTPScope and provide configuration`() {


stephanenicolas · 2019-07-30T05:11:09Z

ktp/src/test/kotlin/toothpick/ktp/KTPTest.kt

+    }
+
+    @Test
+    fun `openScopes should open scopes and wrap child scope using KTPScope`() {


stephanenicolas · 2019-07-30T05:13:21Z

gradle/gradle-mvn-push.gradle

@@ -138,6 +138,7 @@ afterEvaluate { project ->
    task androidJavadocs(type: Javadoc) {
      source = android.sourceSets.main.java.source
      classpath += project.files(android.getBootClasspath().join(File.pathSeparator))
+      excludes = ['**/*.kt']


how can we make that work for kotlin too ?

stephanenicolas · 2019-07-30T05:13:37Z

ktp/src/main/kotlin/toothpick/ktp/KTP.kt

+import toothpick.configuration.Configuration
+import toothpick.ktp.delegate.DelegateNotifier
+
+class KTP : Toothpick() {


Javadoc on all kotlin code !

stephanenicolas · 2019-07-30T05:15:08Z

smoothie-lifecycle-viewmodel/src/main/java/toothpick/smoothie/viewmodel/ViewModelUtil.java

+      if (modelClass.isAssignableFrom(TPViewModel.class)) {
+        return (T) new TPViewModel(scope);
+      }
+      throw new IllegalArgumentException("Unknown ViewModel class: " + modelClass.getName());


"Not a view model class: "

stephanenicolas · 2019-07-30T05:15:19Z

smoothie-lifecycle-viewmodel/src/main/java/toothpick/smoothie/viewmodel/ViewModelUtil.java

+    @Override
+    protected void onCleared() {
+      super.onCleared();
+      closeScope(scope.getName());


inverse order

stephanenicolas · 2019-07-30T05:22:13Z

...ck-compiler/src/main/java/toothpick/compiler/factory/targets/ConstructorInjectionTarget.java

-    this.hasScopeInstancesAnnotation = hasScopeInstancesAnnotation;
+    this.hasSingletonAnnotation = hasSingletonAnnotation;
+    this.hasReleasableAnnotation = hasReleasableAnnotation;
+    this.hasProvidesSingletonInScopeAnnotation = hasProvidesSingletonInScopeAnnotation;


remove InScope

…nload it though...

stephanenicolas · 2019-08-03T01:21:39Z

toothpick-sample/src/main/java/com/example/toothpick/activity/SimpleBackpackItemsActivity.kt

+/**
+ * Simple version of the BackpackItemsActivity.
+ *
+ * Here we do not retain the backpack at all.


In this example the backpack is not retained on configuration changes as it belongs to the activity scope which follows the lifecycle of activity instances: when an instance is destroyed, its associated scope is closed and a new scope with a new backpack will be created when the new instance of the activity is created.

stephanenicolas · 2019-08-03T01:22:56Z

toothpick-sample/src/main/java/com/example/toothpick/activity/AdvancedBackpackItemsActivity.kt

+/**
+ * Advanced version of the BackpackItemsActivity.
+ *
+ * Here we retain the backpack on configuration changes using the ViewModel Scope.


In this example, the backpack is retained on configuration changes as it belongs to the view model scope which follows the lifecycle of view model instances: when an instance is destroyed, and later recreated, the scope remains unchanged and the backpack instance will be the same.

stephanenicolas added 30 commits June 24, 2019 10:04

failing test for implicit singleton when a scope annotation is present

bb58ee9

change scopes to match TP3 Specs: @singleton can now be used with oth…

92a6bfa

…er scopes annotations.

issue 217. Scope.inject(obj)

6a84307

issue 218. small fluent API

ce8ac63

issue 225. scope.supportScopeAnnotation

46c3815

making stuff releasable

dee5f27

finish releasable

54df678

green

1a0e1a8

solve issue #337

d7f819d

use kotlin for toothpick-runtime tests

3ab67d5

add first integration test for kotlin

c6e1e61

add more kotlin tests

7007494

add toothpick kotlin example

44acc18

make the presenter a singleton now.

7ef92f9

fix java sample too

2e7f8f6

make toothpick-kotlin-android-sample work in AS. You have to open it …

2597487

…separately as a new project

use spotless

a61c80f

remove checkstyle

a4bf60d

try to put power mock and mockito, but there are flacky / failing tests

8db30c3

fix powermock and mockito test. It was a version incompatibility issue

b28f2f4

clean up of releasables and more tests

b4d5d46

new DSL that follows the expressivity of annotations. Everything work…

afeec10

… well together. DSL is not yet fully tested. TODO: add the possibility to define in which scope a binding should go based on scope annotations

finalize DSL, add some tests, not exactly there yet. Scoping in DSL w…

fc54648

…orks well, we can now define scope very accurately in the DSL

clean up inScope, make sure that bindings for classes and provider cl…

48dd006

…asses using a scope annotation can only be installed in scope supporting this annotation. It means that all bindings will always be scoped in the scope where they are installed.

conceptual unification of bound provider and scoped providers. Reflec…

1de0e85

…ted in tests, docs and code.

Add architecture components lifecycle support to close scope automati…

8968558

…cally when life cycle owner is destroyed

Less conflicting name

7f77d83

Add architecture component view model support.

b39222a

java 7 is enough for view models. java 8 was necessary for lifecycle …

06c5fea

…extension though

stephanenicolas added 2 commits July 29, 2019 21:36

move tests depending on configuration to a different class. It didn't…

4e35449

… make sense to have them here, we subclass and change the configuration.

prepare version number for RC 1

5baa364

stephanenicolas reviewed Jul 30, 2019

View reviewed changes

stephanenicolas and others added 18 commits July 29, 2019 22:36

Prepare for release 3.0.0-RC1.

c4dff9d

Prepare next development version.

225eb88

updated changelog for TP3

d1efbb4

Update README.md

b8e8212

Update README.md

457ecd8

docs and small refactor of kotlin injection

148c213

enable field injection with qualifier name in KTP

1391e0d

add docs artifacts to release. I don't think IDEs will be able to dow…

4e77267

…nload it though...

Removing old examples

ddb1579

Adding simpleactivity

c13b49a

address PR comments

8e472b1

Chaning activity to use java

b737721

make a class in the sample in java

29b019b

small fixed

35400d9

more elegant binding of the adapter. Restor @InjectConstructor show case

75625ea

more elegant binding of the adapter.

6ba1135

oops

8a12818

Injecting provided viewmodel

c0c84e2

dlemures force-pushed the tp-3 branch from f9c48be to 94a21c4 Compare August 1, 2019 20:18

Adding Advanced activity

70da552

dlemures force-pushed the tp-3 branch from 94a21c4 to 70da552 Compare August 1, 2019 21:59

stephanenicolas reviewed Aug 3, 2019

View reviewed changes

dlemures added 2 commits August 2, 2019 22:08

Adding main activity to navigate to simple and advanced

c04ee95

Fixing styling

7f87a05

dlemures merged commit 5da32be into master Aug 3, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Tp 3 #346

Tp 3 #346

dlemures commented Jul 29, 2019

coveralls commented Jul 30, 2019 •

edited

Loading

stephanenicolas left a comment

stephanenicolas Jul 30, 2019

stephanenicolas Jul 30, 2019

stephanenicolas Jul 30, 2019

stephanenicolas Jul 30, 2019

stephanenicolas Jul 30, 2019

stephanenicolas Jul 30, 2019

stephanenicolas Jul 30, 2019

stephanenicolas Jul 30, 2019

stephanenicolas Jul 30, 2019

stephanenicolas Jul 30, 2019

stephanenicolas Aug 3, 2019 •

edited

Loading

stephanenicolas Aug 3, 2019


		class DelegateNotifier {

		private val delegatesMap: MutableMap<Any, MutableList<InjectDelegate<out Any>>> = Collections.synchronizedMap(WeakHashMap())

Tp 3 #346

Tp 3 #346

Conversation

dlemures commented Jul 29, 2019

coveralls commented Jul 30, 2019 • edited Loading

stephanenicolas left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stephanenicolas Aug 3, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coveralls commented Jul 30, 2019 •

edited

Loading

stephanenicolas Aug 3, 2019 •

edited

Loading