Fixing issue 362 and improvement #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…jector replacement to different class (single responsability)
…ven when delegates are used.
| /** | ||
| * Replaces Toothpick injector to be able to notify delegates. | ||
| */ | ||
| object InjectorReplacer { |
There was a problem hiding this comment.
Or just keep the method or create a proper subclass r.object only for the injector of KTP.
There was a problem hiding this comment.
renamed.
I tried to use an extension functions from within the same package, but it doesnt work cause of the visibility. :(
| } | ||
| } | ||
| init { | ||
| InjectorReplacer.replace() |
There was a problem hiding this comment.
Just do the assignment here and use a dedicated objwct
There was a problem hiding this comment.
cannot do it cause of visiblitiy. Otherwise we would need to make the field protected (instead of package-private) and extend Toothpick (which means, having to go back to companion and KTP.TP....)
| /** | ||
| * Replaces Toothpick injector to be able to notify delegates. | ||
| */ | ||
| object InjectorReplacer { |
dlemures
commented
Aug 29, 2019
| @@ -39,7 +39,7 @@ | |||
| // its transformation | |||
| private static final ConcurrentHashMap<Object, Scope> MAP_KEY_TO_SCOPE = | |||
| new ConcurrentHashMap<>(); | |||
| protected static Injector injector = new InjectorImpl(); | |||
There was a problem hiding this comment.
better package-private
dlemures
force-pushed
the
dlemures/362
branch
2 times, most recently
from
5cacbc9
to
8ce314c
Compare
|
RTM. Thx a lot. Good changes ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following changes:
These changes are improvements that do not change the public API.