Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix background / text color in FF #6

Closed

Conversation

d47081
Copy link

@d47081 d47081 commented Aug 24, 2023

on dark theme environment I have contrast issue in FF, when background color not defined as white. that's small fix just for default white theme even better to have adaptive theme for nightly users.

image

on dark theme environment I have contrast issue in FF, when background color not defined to white. that's small fix just for default white theme even better to have adaptive theme for nightly users.
@d47081
Copy link
Author

d47081 commented Aug 24, 2023

After fixes above, suppose that website should looks like in Chrome on my OS

image

@stephank
Copy link
Owner

stephank commented Sep 1, 2023

Thanks for pointing this out! I decided to go a slightly different route. I recently discovered you can do:

:root {
  color-scheme: light dark;
}

And get dark system colors! So I deployed 0a72e1a and that should work for you too, hopefully?

@d47081
Copy link
Author

d47081 commented Sep 1, 2023

wow, I didn't know this trick!

looks much better, thank you

image

@stephank stephank closed this Sep 1, 2023
@d47081
Copy link
Author

d47081 commented Nov 1, 2023

Just found that FF in light mode now shows gray background with color-scheme implementation :/

image

That's browser issue, but anyway, for info

ps. dark mode works well
pps. tested on linux platform only, maybe just my FF build or my own settings...

image

so fixed for myself with "Use system colors" settings, but not sure about others, theirs defaults

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants