Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to disable animations #79

Open
birdie-github opened this issue Dec 31, 2019 · 9 comments
Open

Add an option to disable animations #79

birdie-github opened this issue Dec 31, 2019 · 9 comments

Comments

@birdie-github
Copy link

They look extremely nice and warm but they kinda slow down all the operations with the add-on - especially scrolling in History.

Please add an option to disable all animations (except maybe the one in the About dialog).

@stephanmahieu
Copy link
Owner

stephanmahieu commented Jan 1, 2020

All animations (except for the scrollbar) are purely css based (no javascript involved) and should have no major impact on performance nor should it slow down anything.

The speed of the scrollbar can be tweaked with the scroll amount preference.

@birdie-github
Copy link
Author

birdie-github commented Jan 1, 2020

should have no major impact on performance nor should it slow down anything.

But they do. I see half a second delay for scrolling using the scroll bar. When animations are off, scrolling is instantaneous. With animations on, it's laggy. Anyways, suit yourself.

Probably I should record a video, so that you could see for yourself.

And my PC is darn fast (Ryzen 7 3700X with 32gigs or RAM).

@stephanmahieu
Copy link
Owner

stephanmahieu commented Jan 1, 2020

I am curious about the delay you have, I have a darn fast pc too (probably a litter slower than yours) but I do not see any delay when scrolling. And how did you turn off animation to get rid of the delay?

@stephanmahieu
Copy link
Owner

stephanmahieu commented Jan 3, 2020

I do see some performance issues with the small popdown window (left-click on icon in toolbar) specially when the pagesize is set to the max of 500 entries. For reasons yet unknown to me cpu and memory allocated to the popdown is limited by the browser and that is the main reason I have limited the pagesize in this panel to 500.

Reducing the scrollinertia helps a little but setting a smaller pagelimit of 100 entries or less dramatically improves the performance, so that is the way to go if you experience annoying delays in this panel.

@birdie-github
Copy link
Author

It's worse than I actually described:

264.zip

If you don't want to fix it - OK, I don't mind. Currently it's just horrible.

@stephanmahieu
Copy link
Owner

That does not look so bad. Anyway I did lower the scroll inertia for the small popup so it should improve by at least a factor 3.
Do you have the same issue with the big popup (right-click, first option)?

@birdie-github
Copy link
Author

birdie-github commented Jan 6, 2020

Do you have the same issue with the big popup (right-click, first option)?

They behave identically in my case.

@stephanmahieu
Copy link
Owner

stephanmahieu commented Jan 10, 2020

I have reduced the scrollbar inertia further down to 500ms (default was 3000). It is now available in v2.5.0.0.
Let me know if you still want it configurable (so you can set it to 0).
Please note that setting inertia to zero will still not prevent the lagging completely, that animation is not parametrized in the scrollbar component (and probably the animation is not the problem here).

@birdie-github
Copy link
Author

It's now much much better though an option to disable it altogether wouldn't hurt. Thanks anyways!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants