Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

showBorders Property only works after the 2nd time of opening a modal with the pdf-viewer #2407

Closed
dusto2020 opened this issue Jun 28, 2024 · 2 comments
Closed

showBorders Property only works after the 2nd time of opening a modal with the pdf-viewer #2407

dusto2020 opened this issue Jun 28, 2024 · 2 comments
Assignees
@stephanrauh
Labels
21 bug Something isn't working Confirmed I've managed to reproduce the bug. That's great news: chances are I'll solve it. Solved

Comments

@dusto2020
Copy link

In my case I came across a bug I believe. I have a button that opens a fullscreen modal which displays my PDF.

I have borders set to false but they still show up.
Only after closing the modal and opening it the second time, they disapear.

I cannot explain how it happens, anyone have any ideas?

I am using ionic with angular
@stephanrauh stephanrauh self-assigned this Jun 28, 2024
@stephanrauh stephanrauh added bug Something isn't working Confirmed I've managed to reproduce the bug. That's great news: chances are I'll solve it. labels Jun 28, 2024
@stephanrauh
Copy link
Owner

I've managed to confirm the bug. Thanks for pointing that out!

stephanrauh added a commit that referenced this issue Jul 7, 2024
@stephanrauh
#2407 initialize the showBorders option before rendering the pages;…
cfb579d 
… explicitely declare compatibility to Angular 18.1.0-rc.*
@stephanrauh
Copy link
Owner

Version 21.0.0-alpha.5 fixes the bug.

Enjoy!
Stephan

@stephanrauh stephanrauh added the 21 label Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stephanrauh stephanrauh

Labels
21 bug Something isn't working Confirmed I've managed to reproduce the bug. That's great news: chances are I'll solve it. Solved
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stephanrauh @dusto2020