[test] add stubs and unit tests

stephantabor · Oct 13, 2015 · f10d267 · f10d267
1 parent ca0843c
commit f10d267
Show file tree

Hide file tree

Showing 8 changed files with 359 additions and 125 deletions.
diff --git a/gulpfile.js b/gulpfile.js
@@ -36,9 +36,9 @@ gulp.task('pre-test', function () {
 gulp.task('test', ['pre-test'], function (cb) {
     var mochaErr;
 
-    gulp.src('test/**/*.js')
+    gulp.src(['test/unit.js', 'test/integration.js'])
         .pipe(plumber())
-        .pipe(mocha({reporter: 'spec'}))
+        .pipe(mocha({reporter: 'nyan'}))
         .on('error', function (err) {
             mochaErr = err;
         })

diff --git a/lib/index.js b/lib/index.js
@@ -3,9 +3,10 @@ import Promise from 'bluebird';
 import {extend, urlJoin} from './utils.js';
 
 class Pkmn {
-    constructor() {
+    constructor(di) {
         this.baseUrl = 'http://pokeapi.co';
         this.queryUrl = urlJoin(this.baseUrl, 'api/v1');
+        this.request = di || request;
     }
 
     static listResources() {
@@ -34,7 +35,7 @@ class Pkmn {
             return this.resource(resource);
         }
         if (/pokedex/.test(resource)) {
-            return this.resource('/api/v1/pokedex/1/');
+            return this.resource('/api/v1/pokedex/1');
         }
         if (id === undefined) {
             return this.buildQuery(resource);
@@ -58,7 +59,7 @@ class Pkmn {
 
     end(query) {
         return new Promise((resolve, reject) => {
-            request
+            this.request
                 .get(query, (err, res, body) => {
                     if (res.statusCode !== 200) {
                         let e = new Error(res.statusCode);

diff --git a/npm-debug.log b/npm-debug.log
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "pkmn",
-  "version": "1.0.4",
+  "version": "1.0.5",
   "description": "a node.js pokeapi.co api wrapper",
   "homepage": "",
   "repository": "stephantabor/pkmn",
@@ -31,7 +31,9 @@
     "gulp-mocha": "^2.0.0",
     "gulp-nsp": "^0.4.5",
     "gulp-plumber": "^1.0.0",
-    "isparta": "^3.0.3"
+    "isparta": "^3.0.3",
+    "rewire": "^2.3.4",
+    "sinon": "^1.17.1"
   },
   "scripts": {
     "prepublish": "gulp prepublish",