Schema builder skipping nested typing types when generating object types

[stephen-bunn]

Expected Behavior

I would expect the built schema of this config class...

from typing import Dict, List
from file_config import config, var, build_schema

@config
class Config(object):
  hooks = var(Dict[str, List[str]])

build_schema(Config)

to return

{ '$id': 'Config.json',
  '$schema': 'http://json-schema.org/draft-07/schema#',
  'properties': { 'hooks': { '$id': '#/properties/hooks',
                             'patternProperties': { '^(.*)$': { 'items': { '$id': '#/properties/hooks/items',
                                                                           'type': 'string'},
                                                                'type': 'array'}},
                             'type': 'object'}},
  'required': ['hooks'],
  'type': 'object'}

Current Behavior

Currently the generated schema comes out looking like this...

{ '$id': 'Config.json',
  '$schema': 'http://json-schema.org/draft-07/schema#',
  'properties': { 'hooks': { '$id': '#/properties/hooks',
                             'patternProperties': { '^(.*)$': {},
                             'type': 'object'}},
  'required': ['hooks'],
  'type': 'object'}

Possible Solution

This is due to the fact that schema_builder@_build is not handling typing types any differently than bulitin types. So when it tries to build the nested typing type (typing.List[str]) it is instead (somewhat silently) failing and returning an empty schema ({})

Solution would be to have a special handler in _build which deals with nested typings. This may also require some changes in the other _build_{type}_type handlers with out modifiers are built (they currently expect config vars if the given type is not a builtin).

Steps to Reproduce (for bugs)

1. Try and run the code show in "Expected Behavior"

Your Environment

• File Config Version: 0.3.1
• Python Version: 3.7
• Operating System and Version: Ubuntu 18.04

---

❤️ Thank you!

[stephen-bunn]

Fixed in commit d8c02c8, published in v0.3.2