This repository has been archived by the owner on Jun 4, 2023. It is now read-only.
Added ability to specify interface and pass ip address to nicercast/nodetunes #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the ability to specify an interface to bind to instead of relying on ip.address(). This was used to solve airsonos #27. This relies on an ip address option being added to nicercast and nodetunes which I submitted pull requests for as well (nicercast: stephen/nicercast#7, nodetunes: stephen/nodetunes#26).
Example useage:
airsonos --interface en0 # Will bind to the ip address of en0
airsonos # Will bind to the ip returned from ip.address(), i.e. legacy behavior
Note: the package.json file in this project would need to be updated to reference the updated versions of nodetunes and nicercast