Skip to content

Commit

Permalink
cleaning up the kubeflow examples to explicitly mention installation …
Browse files Browse the repository at this point in the history
…of s2i in the README, updating the rquirements files to include pandas in the data_download pipeline step, update the requirements to point to the tar of the en_core_web_sm package since it cannot be pip installed, and small formatting changes to pipeline steps (SeldonIO#3654)

Co-authored-by: Alex Lee <alexander.lee@nytimes.com>
  • Loading branch information
westford14 and alee-nyt committed Oct 11, 2021
1 parent 8cf76d3 commit b4bea6b
Show file tree
Hide file tree
Showing 11 changed files with 15 additions and 11 deletions.
1 change: 1 addition & 0 deletions examples/kubeflow/README.md
Expand Up @@ -22,6 +22,7 @@ Make sure you have the following components set-up and running in your Kubernete

* [Seldon Core installed](https://docs.seldon.io/projects/seldon-core/en/latest/workflow/install.html#install-seldon-core-with-helm) with an [ingress (Ambassador / Istio) set up](https://docs.seldon.io/projects/seldon-core/en/latest/workflow/install.html#ingress-support)
* Kubeflow Pipelines [version 1.0.0 Standalone](https://www.kubeflow.org/docs/pipelines/installation/standalone-deployment/#deploying-kubeflow-pipelines) set up
* [s2i](https://github.com/openshift/source-to-image#installation) installed on your machine

Let's get started! 🚀🔥 We will be building the end-to-end pipeline below:

Expand Down
@@ -1,7 +1,8 @@
import re
import logging
from html.parser import HTMLParser

import numpy as np
import logging


class Transformer:
Expand Down
@@ -1,6 +1,6 @@
import dill
import click
import dill

try:
# Running for tests
from .Transformer import Transformer
Expand Down
@@ -1,4 +1,3 @@
dill==0.3.2
click==7.1.2
numpy==1.19.1

@@ -1,6 +1,7 @@
import click
import numpy as np
import dill

import numpy as np
import pandas as pd

@click.command()
Expand Down
Expand Up @@ -2,3 +2,4 @@ dill==0.3.2
click==7.1.2
numpy==1.19.1
scikit-learn==0.23.2
pandas==1.1.1
@@ -1,6 +1,7 @@
import click
import numpy as np
import dill

import numpy as np
from sklearn.linear_model import LogisticRegression

@click.command()
Expand Down
Expand Up @@ -2,5 +2,4 @@ dill==0.3.2
click==7.1.2
numpy==1.19.1
spacy==2.3.2
en-core-web-sm==2.3.1

https://github.com/explosion/spacy-models/releases/download/en_core_web_sm-2.3.1/en_core_web_sm-2.3.1.tar.gz
@@ -1,6 +1,7 @@
import click
import numpy as np
import dill

import numpy as np
from sklearn.feature_extraction.text import TfidfVectorizer

@click.command()
Expand Down
Expand Up @@ -2,4 +2,3 @@ dill==0.3.2
click==7.1.2
numpy==1.19.1
scikit-learn==0.23.2

5 changes: 3 additions & 2 deletions examples/kubeflow/requirements-dev.txt
@@ -1,3 +1,4 @@
dill==0.3.2
python-dateutil==2.8.1
kfp==1.0.0
kubernetes==11.0.0
Expand All @@ -6,5 +7,5 @@ seldon_core==1.2.3
numpy==1.19.1
pandas==1.1.1
spacy==2.3.2
scikit-learn-0.23.2
en-core-web-sm=2.3.1
scikit-learn==0.23.2
https://github.com/explosion/spacy-models/releases/download/en_core_web_sm-2.3.1/en_core_web_sm-2.3.1.tar.gz

0 comments on commit b4bea6b

Please sign in to comment.