Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test/Examples #6

Open
stephenafamo opened this issue Sep 25, 2022 · 6 comments
Open

Test/Examples #6

stephenafamo opened this issue Sep 25, 2022 · 6 comments
Assignees

Comments

@stephenafamo
Copy link
Owner

Add tests for any dialect and query. The tests are used to autogenerate the examples.

Should preferably use a query mod that is not yet used by any existing test.

@Dkingofcode
Copy link

Can i take this issue?

@stephenafamo
Copy link
Owner Author

Sure

@Dkingofcode
Copy link

Sorry, how can i assign myself to this issue?

@stephenafamo
Copy link
Owner Author

Sorry, how can i assign myself to this issue?

I've assigned it to you for now, but this is an ongoing issue since new tests and examples will always be needed.

@Dkingofcode
Copy link

I have read through the codebase, and this is my first time using Go language, i saw four folders in the dialect folder: mssql, mysql, psql and sqlite. Should i write tests for the existing ones or for a new dialect entirely.

@stephenafamo
Copy link
Owner Author

Write tests for the existing dialects. Add to the cases already in select_test.go, update_test.go, insert_test.go and delete_test.go.

The goal is to cover all edge cases when writing a query. Bob should be able to accurately express a valid query.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants