Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add an error catch for deferrerd rows errors #2

Merged
merged 1 commit into from
Mar 28, 2023
Merged

fix: add an error catch for deferrerd rows errors #2

merged 1 commit into from
Mar 28, 2023

Conversation

hiendv
Copy link
Contributor

@hiendv hiendv commented Mar 28, 2023

At the moment, insertion with unique constraint violation reporting sql.ErrNoRows after scanning. This change will report any error populated in rows.

Ref: jackc/pgx#570

@hiendaovinh
Copy link

Ref: https://github.com/jackc/pgx/blob/7555c43/rows.go#L436-L441

@stephenafamo stephenafamo merged commit 6903067 into stephenafamo:main Mar 28, 2023
@stephenafamo
Copy link
Owner

Thank you for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hiendv @hiendaovinh @stephenafamo