CloudBees, Inc. has some internal code review processes. One of the requirements is that we get changes signed off by other CloudBees employees.
To help us identify the Pull requests in GitHub that we need to review, we typically just mention @reviewbybees in the pull request. That lets us see the review requests that we need to review using this handy query.
Our current internal process requires that before we seek to get a change merged we must have either:
- At least two 👍 votes from CloudBees employees; or
- At least one 👍 vote from a CloudBees employee and at least 12 hours since the last commit.
However, that does not mean that you, as a maintainer of your open source project need to pay any attention to our processes:
- If you see a change that you think should be merged, and you want to merge it now, it's your project, so it's your call
- If you see a change that is taking the code in a direction you don't like, tell us... no need to wait while we polish up the pull request if ultimately our proposal would take your project in a different direction.