Handle FK definitions w/o key references #1210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanfallet
approved these changes
May 28, 2023
| @@ -107,7 +107,7 @@ public struct ColumnDefinition: Equatable { | |||
| public struct ForeignKey: Equatable { | |||
There was a problem hiding this comment.
I don't want to sidetrack this. But maybe while you are at it...
The ForeignKey struct is public, but its fields are not. Should they be public as well (given that the fields of ColumnDefinition itself are all are public)?
There was a problem hiding this comment.
yes, quite a few more schema related fields are internal. I don't remember now if this was deliberate, but it looks like they should all be exposed.
|
Please open a new PR if you want to make fields public. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1199