Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for ORDER and LIMIT on UPDATE and DELETE #722

Closed
wants to merge 1 commit into from

Conversation

Dridus
Copy link
Contributor

@Dridus Dridus commented Sep 7, 2017

SQLite supports this syntax when compiled with the SQLITE_ENABLE_UPDATE_DELETE_LIMIT compile option, which Apple apparently does on at least iOS 10.3 and macOS 10.12. Even if it isn't compiled with this option, if the library user specifies an order and limit it gets silently ignored as-is, which seems dangerous.

this fixes #657

@jberkel
Copy link
Collaborator

jberkel commented Sep 16, 2017

Thanks, part of the 0.11.4 branch now

@jberkel jberkel closed this Sep 16, 2017
@Dridus Dridus mentioned this pull request Sep 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LIMIT OFFSET in delete()
2 participants