Make SQLiteCipher's dependencies come in through cocoapods, and therefore resolve all of the build issues #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
March 29, 2016 07:59
…l change so that this can play nice with SQLiteCipher.swift #389) get's approved in the SQLite.swift repo
This was referenced Mar 30, 2016
Making small change so that this can play nice with SQLiteCipher.swift
stephencelis/SQLite.swift#389
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of having this repo pull in SQLite.swift as a submodule, I removed all of those dependencies and instead created a pod file that pulls in SQLite.swift and SQLCipher and handles all of linking for us.
This branch compiles as is, but that is because it's pointing to my fork of SQLite.swift. I'm waiting for a PR to be accepted on the SQLite.swift repository. The change is a single word -
public- in front of thecheck()function in the Connection.swift class.Pending that pull request being approved, I can then lint a pod spec that I have prepared for this repository that should get it up and running again as a fully functioning cocoa pod.
This should solve: #10, #1, #8, #5, #3, and probably #7 as well.
Please let me know if you have any questions or suggestions!