Allow users to specify a Smtp Addr to Open Other Mailboxes using MAPI/HTTP #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
November 18, 2016 09:45
…or RPC, but is required for MAPI/HTTP to open another user's mailbox. You also need KB https://support.microsoft.com/en-us/kb/3114974 if using 2013
| @@ -384,6 +384,7 @@ _Check_return_ HRESULT CreateStoreEntryID2( | |||
| _In_ LPMDB lpMDB, // open message store | |||
| string lpszMsgStoreDN, // desired message store DN | |||
| string lpszMailboxDN, // desired mailbox DN or NULL | |||
| wstring SmtpAddress, | |||
| @@ -404,8 +405,8 @@ _Check_return_ HRESULT CreateStoreEntryID2( | |||
|
|
|||
| if (lpXManageStoreEx) | |||
| { | |||
| DebugPrint(DBGGeneric, L"CreateStoreEntryID2: Creating EntryID. StoreDN = \"%hs\", MailboxDN = \"%hs\"\n", lpszMsgStoreDN.c_str(), lpszMailboxDN.c_str()); | |||
| SPropValue sProps[3] = { 0 }; | |||
| DebugPrint(DBGGeneric, L"CreateStoreEntryID2: Creating EntryID. StoreDN = \"%hs\", MailboxDN = \"%hs\", SmtpAddress = \"%hs\"\n", lpszMsgStoreDN.c_str(), lpszMailboxDN.c_str(), SmtpAddress.c_str()); | |||
There was a problem hiding this comment.
format specifier for wide strings is %ws. %hs is for ansi
| @@ -415,8 +416,11 @@ _Check_return_ HRESULT CreateStoreEntryID2( | |||
| sProps[2].ulPropTag = PR_FORCE_USE_ENTRYID_SERVER; | |||
| sProps[2].Value.b = true; | |||
|
|
|||
| sProps[3].ulPropTag = PR_PROFILE_USER_SMTP_EMAIL_ADDRESS_W; | |||
| sProps[3].Value.lpszW = SmtpAddress.empty() == true ? nullptr : (LPWSTR)SmtpAddress.c_str(); | |||
There was a problem hiding this comment.
use const_cast for the cast here. Also, I think you're safe dropping the .empty() check here since we won't even pass this bit on when we're not using it
There was a problem hiding this comment.
I removed the == true, but I received an error when I tried to remove the .empty().
| @@ -432,6 +436,7 @@ _Check_return_ HRESULT CreateStoreEntryID( | |||
| _In_ LPMDB lpMDB, // open message store | |||
| string lpszMsgStoreDN, // desired message store DN | |||
| string lpszMailboxDN, // desired mailbox DN or NULL | |||
| wstring SmtpAddress, | |||
| @@ -601,7 +609,7 @@ _Check_return_ HRESULT OpenOtherUsersMailbox( | |||
|
|
|||
| *lppOtherUserMDB = nullptr; | |||
|
|
|||
| DebugPrint(DBGGeneric, L"OpenOtherUsersMailbox called with lpMAPISession = %p, lpMDB = %p, Server = \"%hs\", Mailbox = \"%hs\"\n", lpMAPISession, lpMDB, szServerName.c_str(), szMailboxDN.c_str()); | |||
| DebugPrint(DBGGeneric, L"OpenOtherUsersMailbox called with lpMAPISession = %p, lpMDB = %p, Server = \"%hs\", Mailbox = \"%hs\", SmtpAddress = \"%hs\"\n", lpMAPISession, lpMDB, szServerName.c_str(), szMailboxDN.c_str(), SmtpAddress.c_str()); | |||
| @@ -57,6 +57,7 @@ _Check_return_ HRESULT HrMailboxLogon( | |||
| _In_ LPMDB lpMDB, // ptr to message store | |||
| string lpszMsgStoreDN, // ptr to message store DN | |||
| string lpszMailboxDN, // ptr to mailbox DN | |||
| wstring SmtpAddress, | |||
stephenegriffin
requested changes
Nov 21, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let me know if you have questions