Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more supported GLSL versions to Wireframe material definition #3

Conversation

rvandoosselaer
Copy link
Contributor

Resolves #2

@stephengold
Copy link
Owner

Thanks for your contribution. I ran TestSolidMeshes and pressed the N key a few times to ensure that wireframe materials still work on my system.

  1. Would you please run the same test on OpenGL3.2 core profile and report back?
  2. I suspect similar changes will be needed for other J3MDs in the Heart library:
  • ContrastAdjustment.j3md
  • multicolor.j3md
  • multicolor2.j3md

(Particularly multicolor2.j3md, since I know MinieExamples uses it.) If I write tests for those J3MDs, would you run them on OpenGL3.2 core profile and report back?

@stephengold
Copy link
Owner

However, I'm a bit confused about the version numbers. Looking around the web I found these mappings between GLSL and OpenGL. But I don't get why GLSL110 (OpenGL2) is not in the list as this is the default JME renderer.

I don't get it either. You might ask @pspeed42.

@rvandoosselaer
Copy link
Contributor Author

rvandoosselaer commented Mar 25, 2020

Would you please run the same test on OpenGL3.2 core profile and report back?

I added settings.setRenderer(AppSettings.LWJGL_OPENGL32); to the TestSolidMeshes application. I can confirm it is working fine.

(Particularly multicolor2.j3md, since I know MinieExamples uses it.) If I write tests for those J3MDs, would you run them on OpenGL3.2 core profile and report back?

Offcourse, I am glad to help. Let me know when and what I should test.

@stephengold
Copy link
Owner

I'll develop those tests and send you a private message when they're ready.

@stephengold stephengold merged commit da6a4a8 into stephengold:master Mar 25, 2020
@rvandoosselaer rvandoosselaer deleted the opengl32core-support-wireframe-shaders branch March 26, 2020 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shader compilation issue
2 participants