fix: use Long.fromValue instead of Long.fromString for improved robus…

…tness regarding already parsed objects (#405) Co-authored-by: christians <christian.schroeder@consistec.de>
stephenh · Nov 27, 2021 · 7bdc3ee · 7bdc3ee
1 parent 11d333d
commit 7bdc3ee
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/integration/simple-long/simple.ts b/integration/simple-long/simple.ts
@@ -227,7 +227,7 @@ export const SimpleWithMap = {
     );
     message.longLookup = Object.entries(object.longLookup ?? {}).reduce<{ [key: string]: Long }>(
       (acc, [key, value]) => {
-        acc[key] = Long.fromString(value as string);
+        acc[key] = Long.fromValue(value as Long | string);
         return acc;
       },
       {}

diff --git a/src/main.ts b/src/main.ts
@@ -990,7 +990,7 @@ function generateFromJson(ctx: Context, fullName: string, messageDesc: Descripto
                 return code`${utils.bytesFromBase64}(${from} as string)`;
               }
             } else if (isLong(valueType) && options.forceLong === LongOption.LONG) {
-              return code`Long.fromString(${from} as string)`;
+              return code`Long.fromValue(${from} as Long | string)`;
             } else if (isEnum(valueType)) {
               return code`${from} as number`;
             } else {