Skip to content

Commit

Permalink
perf: use Reader.create (#800)
Browse files Browse the repository at this point in the history 
* perf: use Reader.create
Allows protobufjs/minimal to detect the config and optionally
use BufferReader if supported.

* fix: simple service test mock value
  • Loading branch information
@davidzeng0
davidzeng0 committed Mar 18, 2023
1 parent e204531 commit 869e448
Show file tree
Hide file tree
Showing 149 changed files with 606 additions and 606 deletions.
2 changes: 1 addition & 1 deletion integration/angular/simple-message.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ export const SimpleMessage = {
},

decode(input: _m0.Reader | Uint8Array, length?: number): SimpleMessage {
const reader = input instanceof _m0.Reader ? input : new _m0.Reader(input);
const reader = input instanceof _m0.Reader ? input : _m0.Reader.create(input);
let end = length === undefined ? reader.len : reader.pos + length;
const message = createBaseSimpleMessage();
while (reader.pos < end) {
Expand Down
6 changes: 3 additions & 3 deletions integration/async-iterable-services-abort-signal/simple.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export const EchoMsg = {
},

decode(input: _m0.Reader | Uint8Array, length?: number): EchoMsg {
const reader = input instanceof _m0.Reader ? input : new _m0.Reader(input);
const reader = input instanceof _m0.Reader ? input : _m0.Reader.create(input);
let end = length === undefined ? reader.len : reader.pos + length;
const message = createBaseEchoMsg();
while (reader.pos < end) {
Expand Down Expand Up @@ -117,7 +117,7 @@ export class EchoerClientImpl implements Echoer {
Echo(request: EchoMsg, abortSignal?: AbortSignal): Promise<EchoMsg> {
const data = EchoMsg.encode(request).finish();
const promise = this.rpc.request(this.service, "Echo", data, abortSignal || undefined);
return promise.then((data) => EchoMsg.decode(new _m0.Reader(data)));
return promise.then((data) => EchoMsg.decode(_m0.Reader.create(data)));
}

EchoServerStream(request: EchoMsg, abortSignal?: AbortSignal): AsyncIterable<EchoMsg> {
Expand All @@ -129,7 +129,7 @@ export class EchoerClientImpl implements Echoer {
EchoClientStream(request: AsyncIterable<EchoMsg>, abortSignal?: AbortSignal): Promise<EchoMsg> {
const data = EchoMsg.encodeTransform(request);
const promise = this.rpc.clientStreamingRequest(this.service, "EchoClientStream", data, abortSignal || undefined);
return promise.then((data) => EchoMsg.decode(new _m0.Reader(data)));
return promise.then((data) => EchoMsg.decode(_m0.Reader.create(data)));
}

EchoBidiStream(request: AsyncIterable<EchoMsg>, abortSignal?: AbortSignal): AsyncIterable<EchoMsg> {
Expand Down
6 changes: 3 additions & 3 deletions integration/async-iterable-services/simple.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export const EchoMsg = {
},

decode(input: _m0.Reader | Uint8Array, length?: number): EchoMsg {
const reader = input instanceof _m0.Reader ? input : new _m0.Reader(input);
const reader = input instanceof _m0.Reader ? input : _m0.Reader.create(input);
let end = length === undefined ? reader.len : reader.pos + length;
const message = createBaseEchoMsg();
while (reader.pos < end) {
Expand Down Expand Up @@ -117,7 +117,7 @@ export class EchoerClientImpl implements Echoer {
Echo(request: EchoMsg): Promise<EchoMsg> {
const data = EchoMsg.encode(request).finish();
const promise = this.rpc.request(this.service, "Echo", data);
return promise.then((data) => EchoMsg.decode(new _m0.Reader(data)));
return promise.then((data) => EchoMsg.decode(_m0.Reader.create(data)));
}

EchoServerStream(request: EchoMsg): AsyncIterable<EchoMsg> {
Expand All @@ -129,7 +129,7 @@ export class EchoerClientImpl implements Echoer {
EchoClientStream(request: AsyncIterable<EchoMsg>): Promise<EchoMsg> {
const data = EchoMsg.encodeTransform(request);
const promise = this.rpc.clientStreamingRequest(this.service, "EchoClientStream", data);
return promise.then((data) => EchoMsg.decode(new _m0.Reader(data)));
return promise.then((data) => EchoMsg.decode(_m0.Reader.create(data)));
}

EchoBidiStream(request: AsyncIterable<EchoMsg>): AsyncIterable<EchoMsg> {
Expand Down
10 changes: 5 additions & 5 deletions integration/avoid-import-conflicts/simple.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ export const Simple = {
},

decode(input: _m0.Reader | Uint8Array, length?: number): Simple {
const reader = input instanceof _m0.Reader ? input : new _m0.Reader(input);
const reader = input instanceof _m0.Reader ? input : _m0.Reader.create(input);
let end = length === undefined ? reader.len : reader.pos + length;
const message = createBaseSimple();
while (reader.pos < end) {
Expand Down Expand Up @@ -150,7 +150,7 @@ export const SimpleEnums = {
},

decode(input: _m0.Reader | Uint8Array, length?: number): SimpleEnums {
const reader = input instanceof _m0.Reader ? input : new _m0.Reader(input);
const reader = input instanceof _m0.Reader ? input : _m0.Reader.create(input);
let end = length === undefined ? reader.len : reader.pos + length;
const message = createBaseSimpleEnums();
while (reader.pos < end) {
Expand Down Expand Up @@ -209,7 +209,7 @@ export const FooServiceCreateRequest = {
},

decode(input: _m0.Reader | Uint8Array, length?: number): FooServiceCreateRequest {
const reader = input instanceof _m0.Reader ? input : new _m0.Reader(input);
const reader = input instanceof _m0.Reader ? input : _m0.Reader.create(input);
let end = length === undefined ? reader.len : reader.pos + length;
const message = createBaseFooServiceCreateRequest();
while (reader.pos < end) {
Expand Down Expand Up @@ -260,7 +260,7 @@ export const FooServiceCreateResponse = {
},

decode(input: _m0.Reader | Uint8Array, length?: number): FooServiceCreateResponse {
const reader = input instanceof _m0.Reader ? input : new _m0.Reader(input);
const reader = input instanceof _m0.Reader ? input : _m0.Reader.create(input);
let end = length === undefined ? reader.len : reader.pos + length;
const message = createBaseFooServiceCreateResponse();
while (reader.pos < end) {
Expand Down Expand Up @@ -313,7 +313,7 @@ export class FooServiceClientImpl implements FooService {
Create(request: FooServiceCreateRequest): Promise<FooServiceCreateResponse> {
const data = FooServiceCreateRequest.encode(request).finish();
const promise = this.rpc.request(this.service, "Create", data);
return promise.then((data) => FooServiceCreateResponse.decode(new _m0.Reader(data)));
return promise.then((data) => FooServiceCreateResponse.decode(_m0.Reader.create(data)));
}
}

Expand Down
2 changes: 1 addition & 1 deletion integration/avoid-import-conflicts/simple2.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ export const Simple = {
},

decode(input: _m0.Reader | Uint8Array, length?: number): Simple {
const reader = input instanceof _m0.Reader ? input : new _m0.Reader(input);
const reader = input instanceof _m0.Reader ? input : _m0.Reader.create(input);
let end = length === undefined ? reader.len : reader.pos + length;
const message = createBaseSimple();
while (reader.pos < end) {
Expand Down
2 changes: 1 addition & 1 deletion integration/barrel-imports/bar.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export const Bar = {
},

decode(input: _m0.Reader | Uint8Array, length?: number): Bar {
const reader = input instanceof _m0.Reader ? input : new _m0.Reader(input);
const reader = input instanceof _m0.Reader ? input : _m0.Reader.create(input);
let end = length === undefined ? reader.len : reader.pos + length;
const message = createBaseBar();
while (reader.pos < end) {
Expand Down
2 changes: 1 addition & 1 deletion integration/barrel-imports/foo.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export const Foo = {
},

decode(input: _m0.Reader | Uint8Array, length?: number): Foo {
const reader = input instanceof _m0.Reader ? input : new _m0.Reader(input);
const reader = input instanceof _m0.Reader ? input : _m0.Reader.create(input);
let end = length === undefined ? reader.len : reader.pos + length;
const message = createBaseFoo();
while (reader.pos < end) {
Expand Down
28 changes: 14 additions & 14 deletions integration/batching-with-context/batching.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ export const BatchQueryRequest = {
},

decode(input: _m0.Reader | Uint8Array, length?: number): BatchQueryRequest {
const reader = input instanceof _m0.Reader ? input : new _m0.Reader(input);
const reader = input instanceof _m0.Reader ? input : _m0.Reader.create(input);
let end = length === undefined ? reader.len : reader.pos + length;
const message = createBaseBatchQueryRequest();
while (reader.pos < end) {
Expand Down Expand Up @@ -114,7 +114,7 @@ export const BatchQueryResponse = {
},

decode(input: _m0.Reader | Uint8Array, length?: number): BatchQueryResponse {
const reader = input instanceof _m0.Reader ? input : new _m0.Reader(input);
const reader = input instanceof _m0.Reader ? input : _m0.Reader.create(input);
let end = length === undefined ? reader.len : reader.pos + length;
const message = createBaseBatchQueryResponse();
while (reader.pos < end) {
Expand Down Expand Up @@ -169,7 +169,7 @@ export const BatchMapQueryRequest = {
},

decode(input: _m0.Reader | Uint8Array, length?: number): BatchMapQueryRequest {
const reader = input instanceof _m0.Reader ? input : new _m0.Reader(input);
const reader = input instanceof _m0.Reader ? input : _m0.Reader.create(input);
let end = length === undefined ? reader.len : reader.pos + length;
const message = createBaseBatchMapQueryRequest();
while (reader.pos < end) {
Expand Down Expand Up @@ -224,7 +224,7 @@ export const BatchMapQueryResponse = {
},

decode(input: _m0.Reader | Uint8Array, length?: number): BatchMapQueryResponse {
const reader = input instanceof _m0.Reader ? input : new _m0.Reader(input);
const reader = input instanceof _m0.Reader ? input : _m0.Reader.create(input);
let end = length === undefined ? reader.len : reader.pos + length;
const message = createBaseBatchMapQueryResponse();
while (reader.pos < end) {
Expand Down Expand Up @@ -298,7 +298,7 @@ export const BatchMapQueryResponse_EntitiesEntry = {
},

decode(input: _m0.Reader | Uint8Array, length?: number): BatchMapQueryResponse_EntitiesEntry {
const reader = input instanceof _m0.Reader ? input : new _m0.Reader(input);
const reader = input instanceof _m0.Reader ? input : _m0.Reader.create(input);
let end = length === undefined ? reader.len : reader.pos + length;
const message = createBaseBatchMapQueryResponse_EntitiesEntry();
while (reader.pos < end) {
Expand Down Expand Up @@ -363,7 +363,7 @@ export const GetOnlyMethodRequest = {
},

decode(input: _m0.Reader | Uint8Array, length?: number): GetOnlyMethodRequest {
const reader = input instanceof _m0.Reader ? input : new _m0.Reader(input);
const reader = input instanceof _m0.Reader ? input : _m0.Reader.create(input);
let end = length === undefined ? reader.len : reader.pos + length;
const message = createBaseGetOnlyMethodRequest();
while (reader.pos < end) {
Expand Down Expand Up @@ -414,7 +414,7 @@ export const GetOnlyMethodResponse = {
},

decode(input: _m0.Reader | Uint8Array, length?: number): GetOnlyMethodResponse {
const reader = input instanceof _m0.Reader ? input : new _m0.Reader(input);
const reader = input instanceof _m0.Reader ? input : _m0.Reader.create(input);
let end = length === undefined ? reader.len : reader.pos + length;
const message = createBaseGetOnlyMethodResponse();
while (reader.pos < end) {
Expand Down Expand Up @@ -467,7 +467,7 @@ export const WriteMethodRequest = {
},

decode(input: _m0.Reader | Uint8Array, length?: number): WriteMethodRequest {
const reader = input instanceof _m0.Reader ? input : new _m0.Reader(input);
const reader = input instanceof _m0.Reader ? input : _m0.Reader.create(input);
let end = length === undefined ? reader.len : reader.pos + length;
const message = createBaseWriteMethodRequest();
while (reader.pos < end) {
Expand Down Expand Up @@ -515,7 +515,7 @@ export const WriteMethodResponse = {
},

decode(input: _m0.Reader | Uint8Array, length?: number): WriteMethodResponse {
const reader = input instanceof _m0.Reader ? input : new _m0.Reader(input);
const reader = input instanceof _m0.Reader ? input : _m0.Reader.create(input);
let end = length === undefined ? reader.len : reader.pos + length;
const message = createBaseWriteMethodResponse();
while (reader.pos < end) {
Expand Down Expand Up @@ -564,7 +564,7 @@ export const Entity = {
},

decode(input: _m0.Reader | Uint8Array, length?: number): Entity {
const reader = input instanceof _m0.Reader ? input : new _m0.Reader(input);
const reader = input instanceof _m0.Reader ? input : _m0.Reader.create(input);
let end = length === undefined ? reader.len : reader.pos + length;
const message = createBaseEntity();
while (reader.pos < end) {
Expand Down Expand Up @@ -642,7 +642,7 @@ export class EntityServiceClientImpl<Context extends DataLoaders> implements Ent
BatchQuery(ctx: Context, request: BatchQueryRequest): Promise<BatchQueryResponse> {
const data = BatchQueryRequest.encode(request).finish();
const promise = this.rpc.request(ctx, this.service, "BatchQuery", data);
return promise.then((data) => BatchQueryResponse.decode(new _m0.Reader(data)));
return promise.then((data) => BatchQueryResponse.decode(_m0.Reader.create(data)));
}

GetMapQuery(ctx: Context, id: string): Promise<Entity> {
Expand All @@ -660,7 +660,7 @@ export class EntityServiceClientImpl<Context extends DataLoaders> implements Ent
BatchMapQuery(ctx: Context, request: BatchMapQueryRequest): Promise<BatchMapQueryResponse> {
const data = BatchMapQueryRequest.encode(request).finish();
const promise = this.rpc.request(ctx, this.service, "BatchMapQuery", data);
return promise.then((data) => BatchMapQueryResponse.decode(new _m0.Reader(data)));
return promise.then((data) => BatchMapQueryResponse.decode(_m0.Reader.create(data)));
}

GetOnlyMethod(ctx: Context, request: GetOnlyMethodRequest): Promise<GetOnlyMethodResponse> {
Expand All @@ -669,7 +669,7 @@ export class EntityServiceClientImpl<Context extends DataLoaders> implements Ent
const responses = requests.map(async (request) => {
const data = GetOnlyMethodRequest.encode(request).finish();
const response = await this.rpc.request(ctx, "batching.EntityService", "GetOnlyMethod", data);
return GetOnlyMethodResponse.decode(new _m0.Reader(response));
return GetOnlyMethodResponse.decode(_m0.Reader.create(response));
});
return Promise.all(responses);
}, { cacheKeyFn: hash, ...ctx.rpcDataLoaderOptions });
Expand All @@ -680,7 +680,7 @@ export class EntityServiceClientImpl<Context extends DataLoaders> implements Ent
WriteMethod(ctx: Context, request: WriteMethodRequest): Promise<WriteMethodResponse> {
const data = WriteMethodRequest.encode(request).finish();
const promise = this.rpc.request(ctx, this.service, "WriteMethod", data);
return promise.then((data) => WriteMethodResponse.decode(new _m0.Reader(data)));
return promise.then((data) => WriteMethodResponse.decode(_m0.Reader.create(data)));
}
}

Expand Down
28 changes: 14 additions & 14 deletions integration/batching/batching.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ export const BatchQueryRequest = {
},

decode(input: _m0.Reader | Uint8Array, length?: number): BatchQueryRequest {
const reader = input instanceof _m0.Reader ? input : new _m0.Reader(input);
const reader = input instanceof _m0.Reader ? input : _m0.Reader.create(input);
let end = length === undefined ? reader.len : reader.pos + length;
const message = createBaseBatchQueryRequest();
while (reader.pos < end) {
Expand Down Expand Up @@ -112,7 +112,7 @@ export const BatchQueryResponse = {
},

decode(input: _m0.Reader | Uint8Array, length?: number): BatchQueryResponse {
const reader = input instanceof _m0.Reader ? input : new _m0.Reader(input);
const reader = input instanceof _m0.Reader ? input : _m0.Reader.create(input);
let end = length === undefined ? reader.len : reader.pos + length;
const message = createBaseBatchQueryResponse();
while (reader.pos < end) {
Expand Down Expand Up @@ -167,7 +167,7 @@ export const BatchMapQueryRequest = {
},

decode(input: _m0.Reader | Uint8Array, length?: number): BatchMapQueryRequest {
const reader = input instanceof _m0.Reader ? input : new _m0.Reader(input);
const reader = input instanceof _m0.Reader ? input : _m0.Reader.create(input);
let end = length === undefined ? reader.len : reader.pos + length;
const message = createBaseBatchMapQueryRequest();
while (reader.pos < end) {
Expand Down Expand Up @@ -222,7 +222,7 @@ export const BatchMapQueryResponse = {
},

decode(input: _m0.Reader | Uint8Array, length?: number): BatchMapQueryResponse {
const reader = input instanceof _m0.Reader ? input : new _m0.Reader(input);
const reader = input instanceof _m0.Reader ? input : _m0.Reader.create(input);
let end = length === undefined ? reader.len : reader.pos + length;
const message = createBaseBatchMapQueryResponse();
while (reader.pos < end) {
Expand Down Expand Up @@ -296,7 +296,7 @@ export const BatchMapQueryResponse_EntitiesEntry = {
},

decode(input: _m0.Reader | Uint8Array, length?: number): BatchMapQueryResponse_EntitiesEntry {
const reader = input instanceof _m0.Reader ? input : new _m0.Reader(input);
const reader = input instanceof _m0.Reader ? input : _m0.Reader.create(input);
let end = length === undefined ? reader.len : reader.pos + length;
const message = createBaseBatchMapQueryResponse_EntitiesEntry();
while (reader.pos < end) {
Expand Down Expand Up @@ -361,7 +361,7 @@ export const GetOnlyMethodRequest = {
},

decode(input: _m0.Reader | Uint8Array, length?: number): GetOnlyMethodRequest {
const reader = input instanceof _m0.Reader ? input : new _m0.Reader(input);
const reader = input instanceof _m0.Reader ? input : _m0.Reader.create(input);
let end = length === undefined ? reader.len : reader.pos + length;
const message = createBaseGetOnlyMethodRequest();
while (reader.pos < end) {
Expand Down Expand Up @@ -412,7 +412,7 @@ export const GetOnlyMethodResponse = {
},

decode(input: _m0.Reader | Uint8Array, length?: number): GetOnlyMethodResponse {
const reader = input instanceof _m0.Reader ? input : new _m0.Reader(input);
const reader = input instanceof _m0.Reader ? input : _m0.Reader.create(input);
let end = length === undefined ? reader.len : reader.pos + length;
const message = createBaseGetOnlyMethodResponse();
while (reader.pos < end) {
Expand Down Expand Up @@ -465,7 +465,7 @@ export const WriteMethodRequest = {
},

decode(input: _m0.Reader | Uint8Array, length?: number): WriteMethodRequest {
const reader = input instanceof _m0.Reader ? input : new _m0.Reader(input);
const reader = input instanceof _m0.Reader ? input : _m0.Reader.create(input);
let end = length === undefined ? reader.len : reader.pos + length;
const message = createBaseWriteMethodRequest();
while (reader.pos < end) {
Expand Down Expand Up @@ -513,7 +513,7 @@ export const WriteMethodResponse = {
},

decode(input: _m0.Reader | Uint8Array, length?: number): WriteMethodResponse {
const reader = input instanceof _m0.Reader ? input : new _m0.Reader(input);
const reader = input instanceof _m0.Reader ? input : _m0.Reader.create(input);
let end = length === undefined ? reader.len : reader.pos + length;
const message = createBaseWriteMethodResponse();
while (reader.pos < end) {
Expand Down Expand Up @@ -562,7 +562,7 @@ export const Entity = {
},

decode(input: _m0.Reader | Uint8Array, length?: number): Entity {
const reader = input instanceof _m0.Reader ? input : new _m0.Reader(input);
const reader = input instanceof _m0.Reader ? input : _m0.Reader.create(input);
let end = length === undefined ? reader.len : reader.pos + length;
const message = createBaseEntity();
while (reader.pos < end) {
Expand Down Expand Up @@ -628,25 +628,25 @@ export class EntityServiceClientImpl implements EntityService {
BatchQuery(request: BatchQueryRequest): Promise<BatchQueryResponse> {
const data = BatchQueryRequest.encode(request).finish();
const promise = this.rpc.request(this.service, "BatchQuery", data);
return promise.then((data) => BatchQueryResponse.decode(new _m0.Reader(data)));
return promise.then((data) => BatchQueryResponse.decode(_m0.Reader.create(data)));
}

BatchMapQuery(request: BatchMapQueryRequest): Promise<BatchMapQueryResponse> {
const data = BatchMapQueryRequest.encode(request).finish();
const promise = this.rpc.request(this.service, "BatchMapQuery", data);
return promise.then((data) => BatchMapQueryResponse.decode(new _m0.Reader(data)));
return promise.then((data) => BatchMapQueryResponse.decode(_m0.Reader.create(data)));
}

GetOnlyMethod(request: GetOnlyMethodRequest): Promise<GetOnlyMethodResponse> {
const data = GetOnlyMethodRequest.encode(request).finish();
const promise = this.rpc.request(this.service, "GetOnlyMethod", data);
return promise.then((data) => GetOnlyMethodResponse.decode(new _m0.Reader(data)));
return promise.then((data) => GetOnlyMethodResponse.decode(_m0.Reader.create(data)));
}

WriteMethod(request: WriteMethodRequest): Promise<WriteMethodResponse> {
const data = WriteMethodRequest.encode(request).finish();
const promise = this.rpc.request(this.service, "WriteMethod", data);
return promise.then((data) => WriteMethodResponse.decode(new _m0.Reader(data)));
return promise.then((data) => WriteMethodResponse.decode(_m0.Reader.create(data)));
}
}

Expand Down

0 comments on commit 869e448

Please sign in to comment.