-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: typescript errors for struct with optional=all #1008
Conversation
Hi @UnderKoen , thanks for the PR! Can you run Given that ts-proto's primary output is generated code, we go ahead and commit the generated code to the repo because it forms ts-protos regression suite. Thanks! |
@stephenh Thanks for the information. I have pushed that in the pr! |
@UnderKoen sorry, looks like just a formatting thing, if you don't mind fixing that? 🙏 Thanks! |
@stephenh Done! |
Looks great, thanks @UnderKoen ! |
🎉 This PR is included in version 1.167.9 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Fixes #578
Due to the use of the
.foreach
function TS has no context of the clue thatstruct.fields
is definently not undefined.