fix: typescript errors for struct with optional=all #1008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @UnderKoen , thanks for the PR! Can you run Given that ts-proto's primary output is generated code, we go ahead and commit the generated code to the repo because it forms ts-protos regression suite. Thanks! |
|
@stephenh Thanks for the information. I have pushed that in the pr! |
|
@UnderKoen sorry, looks like just a formatting thing, if you don't mind fixing that? 🙏 Thanks! |
|
@stephenh Done! |
|
Looks great, thanks @UnderKoen ! |
|
🎉 This PR is included in version 1.167.9 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #578
Due to the use of the
.foreachfunction TS has no context of the clue thatstruct.fieldsis definently not undefined.