Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

outputServices=grpc-js always generates client stub #471

Closed
alexeyten opened this issue Jan 10, 2022 · 1 comment
Closed

outputServices=grpc-js always generates client stub #471

alexeyten opened this issue Jan 10, 2022 · 1 comment

Comments

@alexeyten
Copy link
Contributor

I've tried to use options --ts_proto_opt=esModuleInterop=true,outputServices=grpc-js,outputClientImpl=false, but interface TestClient extends Client { ... } and const TestClient = makeGenericClientConstructor(...) are always generated.

I guess it's because there is no options check in https://github.com/stephenh/ts-proto/blob/main/src/generate-grpc-js.ts#L41-L42

So far, I've found that outputClientImpl option has effect only for outputServices=default.
alexeyten added a commit to alexeyten/ts-proto that referenced this issue Jan 10, 2022
@alexeyten
fix: respect generateClientImpl=false in grpc-js (stephenh#471)
8d41f1c 
Do not generate client stub and constructor when `outputServices=grpc-js` and `outputClientImpl=false`
stephenh pushed a commit that referenced this issue Jan 10, 2022
@alexeyten
fix: respect generateClientImpl=false in grpc-js (#471) (#472)
2f389f2 
Do not generate client stub and constructor when `outputServices=grpc-js` and `outputClientImpl=false`
stephenh pushed a commit that referenced this issue Jan 10, 2022
@semantic-release-bot
chore(release): 1.100.1 [skip ci]
2e4cb6b 
## [1.100.1](v1.100.0...v1.100.1) (2022-01-10)

### Bug Fixes

* respect generateClientImpl=false in grpc-js ([#471](#471)) ([#472](#472)) ([2f389f2](2f389f2))
@stephenh
Copy link
Owner

Closing as fixed in #472 ; thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stephenh @alexeyten