Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nestjs does not transform dates #550

Closed
alexvallecit opened this issue Apr 18, 2022 · 1 comment
Closed

Nestjs does not transform dates #550

alexvallecit opened this issue Apr 18, 2022 · 1 comment

Comments

@alexvallecit
Copy link

When using the --ts_proto_opt=nestJs=true option it does not create the functionality to switch from Timestamp to Date.

@stephenh
Copy link
Owner

stephenh commented May 1, 2022

Hi @alexvallecit ; yeah, you're right; this is a known issue with the NestJS infra and is discussed in #69.

Note that #69 has been open for awhile, but ~a month ago someone did finally figure out how to tell the protobufjs runtime to use ts-proto's custom encode/decode methods for things like dates, but unfortunately that insight has not been turned into a PR that works for all types yet.

If you're interesting in helping fix that, check that issue out.

Thanks!

@stephenh stephenh closed this as completed May 1, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants